Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Hyperdrive Worker binding to more align with wrangler syntax #2932

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

OilyLime
Copy link
Contributor

@OilyLime OilyLime commented Aug 22, 2024

It works either way, but using "binding" instead of "name" in this API more aligns with our wrangler syntax https://developers.cloudflare.com/hyperdrive/get-started/#4-bind-your-worker-to-hyperdrive

Description

Very slight adjustment to the Hyperdrive Binding struct to use Binding instead of the implicit name as the identifier to more align with how users bind Hyperdrive configs to their workers via wrangler.toml files.

Has your change been tested?

Covered by existing test suites.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

It works either way, but using "binding" instead of "name" in this API
more aligns with our wrangler syntax https://developers.cloudflare.com/hyperdrive/get-started/#4-bind-your-worker-to-hyperdrive
Copy link
Contributor

github-actions bot commented Aug 22, 2024

changelog detected ✅

@jacobbednarz jacobbednarz merged commit 60f64ed into cloudflare:master Aug 26, 2024
18 checks passed
@github-actions github-actions bot added this to the v0.103.0 milestone Aug 26, 2024
Copy link
Contributor

This functionality has been released in v0.103.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants