-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic support for account load balancers #3027
Basic support for account load balancers #3027
Conversation
Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/cloudflare-go/blob/master/docs/changelog-process.md. Example:
If you do not require a release note to be included, please add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as the CRUD method signatures already include the *ResourceContainer
we can add a condition inside of those methods for the account level load balancers instead of using seperate new methods (we already have zone + user).
6612382
to
53fad58
Compare
the changelog check blows up on a go version mismatch but I've updated the functions to switch on the resource container level |
updated the usage of the i'll take a look at the changelog test failure but it looks correct for the usage here. |
oh that's a very nice improvement I didn't realize the constants actually were the text strings at the end of the day. |
This functionality has been released in v0.105.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Basic support for account level load balancers.
Has your change been tested?
Duplicated the existing zone tests and altered them for account based LB which are identical except they don't have a "name".
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.