Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for custom_s2s posture rule #3031

Merged

Conversation

jlu-cloudflare
Copy link
Contributor

@jlu-cloudflare jlu-cloudflare commented Sep 7, 2024

Description

Added 'score' field to DevicePostureRuleInput to accommodate needed input for the new posture types: custom_s2s.
(pending documentation)

Has your change been tested?

Because it is just adding fields to the DevicePostureRuleInput struct, this should not affect existing uses of it.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Sep 7, 2024

changelog detected ✅

@jlu-cloudflare jlu-cloudflare marked this pull request as ready for review September 12, 2024 03:03
@jacobbednarz jacobbednarz merged commit 654a92f into cloudflare:master Sep 17, 2024
12 checks passed
@github-actions github-actions bot added this to the v0.105.0 milestone Sep 17, 2024
Copy link
Contributor

This functionality has been released in v0.105.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants