Fix disabling redact PII on logging settings #3577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
reviewed
Nov 8, 2024
Trying to disable redact PII on the logging settings would have no effect because the logging settings object would be marshaled without the `redact_pii` field which result in the default value being used, which is `true` in this case. To fix this, the `redact_pii` is now included even set to `false` when the logging settings object is marshaled.
|
This functionality has been released in v0.110.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying to disable redact PII on the logging
settings would have no effect because the logging
settings object would be marshaled without the
redact_piifield which result in the defaultvalue being used, which is
truein this case.To fix this, the
redact_piiis now includedeven set to
falsewhen the logging settingsobject is marshaled.
Has your change been tested?
Besides the automated test, the change was
manually validated by using the lib to call
the API to make the change that was causing
problems.
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.