Fix turnstile's UpdateTurnstileWidgetParams #3594
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We do not allow changing the region, so remove that.
There is a meaningful difference between setting a field to nil vs false: in one case, the previous value is kept. In the other, the false is used. With omitempty, go did the wrong thing–and prevented setting values to false (as they would NOT be sent over the wire).
Has your change been tested?
🤷
Types of changes
What sort of change does your code introduce/modify?
I guess it's technically a breaking change to fix this. The alternative is to either always set all fields, but then
UpdateTurnstileWidgetParams{domains: ...}
would override EVERYTHING else, and that is a much worse breaking change.Checklist:
and relies on stable APIs.