Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag argument = expected string slice found string for tag #312

Closed
centminmod opened this issue Feb 14, 2021 · 3 comments
Closed

tag argument = expected string slice found string for tag #312

centminmod opened this issue Feb 14, 2021 · 3 comments

Comments

@centminmod
Copy link

Does the tag argument work in config.yml https://developers.cloudflare.com/cloudflare-one/connections/connect-apps/configuration/arguments#--tag ?

I tried in config.yml

tag: cmm=test

and get

cloudflared tunnel --config ~/.cloudflared/config.yml run tun.domain.com
expected string slice found string for tag
cloudflared --version
cloudflared version 2021.2.1 (built 2021-02-04-1528 UTC)
@adamchalmers
Copy link
Contributor

Hi there, the tag doesn't do anything currently, it was originally added to Argo Tunnel in its early testing/development phase and we haven't wanted to remove it for backwards compatibility reasons.

@centminmod
Copy link
Author

thanks @adamchalmers for the clarification

I did find git repo tags are formatted differently in config.yml example at https://github.com/cloudflare/cloudflared/blob/master/cmd/cloudflared/config/configuration_test.go#L36-L38 compared to https://developers.cloudflare.com/cloudflare-one/connections/connect-apps/configuration/arguments#--tag

tunnel: config-file-test
ingress:
 - hostname: tunnel1.example.com
   path: /id
   service: https://localhost:8000
 - hostname: "*"
   service: https://localhost:8001
retries: 5
grace-period: 30s
percentage: 3.14
hostname: example.com
tag:
 - test
 - central-1
counters:
 - 123
 - 456

@adamchalmers
Copy link
Contributor

You mentioned "git repo tags", but the tags you linked don't refer to git tags at all. They're just custom tags you can give your tunnels to help organize them in a hypothetical UI. As I mentioned, we don't surface them, they're really a leftover legacy concept and we haven't removed them because we don't want to break backwards-compatibility. We should remove them from the docs though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants