Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the secure decoder version #5

Closed
Cyan4973 opened this issue Jul 11, 2014 · 1 comment
Closed

Use the secure decoder version #5

Cyan4973 opened this issue Jul 11, 2014 · 1 comment

Comments

@Cyan4973
Copy link

It seems this binding is using the unsafe version of the decoder (LZ4_uncompress). As a consequence, a malicious user could slip-in some forged input to trigger an attack.

As a way to improve security, it would be better to use the safe version instead.
The safe version is called LZ4_decompress_safe().
It's also recommended to update the C source to r119, which improves security for 32-bits systems.

@jgrahamc
Copy link
Contributor

Thanks. I've done both.

C source is now r119 and switched to LZ4_decompress_safe.

flapjack103 referenced this issue in DataDog/golz4 Nov 13, 2019
[lz4-2]Try new termination condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants