Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage-file -> readFileRange does not respect symbolic links #318

Closed
CraigglesO opened this issue Jul 20, 2022 · 0 comments · Fixed by #319
Closed

storage-file -> readFileRange does not respect symbolic links #318

CraigglesO opened this issue Jul 20, 2022 · 0 comments · Fixed by #319
Labels
bug Something isn't working
Milestone
2.7.0

Comments

@CraigglesO
Copy link
Contributor

https://github.com/cloudflare/miniflare/blob/master/packages/storage-file/src/helpers.ts#L40

If a file is a symbolic link, the size of the symbolic link is returned rather than the actual file size.

This can be fixed by using realpath

I can fix it this weekend if a PR hasn't been created by then.
@CraigglesO CraigglesO mentioned this issue Jul 21, 2022
Merged
@mrbbot mrbbot added the bug Something isn't working label Aug 11, 2022
@mrbbot mrbbot added this to the 2.7.0 milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

add realpath CraigglesO/miniflare
2 participants
@CraigglesO @mrbbot