This repository was archived by the owner on Sep 29, 2025. It is now read-only.
support prerendered api functions#826
Merged
dario-piotrowicz merged 3 commits intocloudflare:mainfrom Jul 10, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: d826d23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
🧪 Prereleases are available for testing 🧪 Details@cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/9872893500/npm-package-next-on-pages-826@cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/9872893500/npm-package-eslint-plugin-next-on-pages-826 |
dario-piotrowicz
approved these changes
Jul 10, 2024
Member
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
Thanks a lot @james-elicx , awesome stuff as always! 🫶
(PS: I just left a couple of nits)
packages/next-on-pages/src/buildApplication/processVercelFunctions/configs.ts
Outdated
Show resolved
Hide resolved
packages/next-on-pages/src/buildApplication/processVercelFunctions/configs.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #825
new vercel cli release changed the vc-config type for favicon.ico to
API, so added a check for if anAPIfunction has a prerendered config existing...(rolling eyes)