Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

fixed bug where entire application would fail, in cases where process.versions is undefined #73

Closed
wants to merge 3 commits into from

Conversation

Xayer
Copy link

@Xayer Xayer commented Jul 4, 2020

In web applications such as Vue.js, process.versions is not available.
This causes the entire application to crash.
Here's an easy fix, but feel free to suggest a better solution.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.597% when pulling b31ea74 on Xayer:master into 41568a5 on cloudflare:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.597% when pulling b31ea74 on Xayer:master into 41568a5 on cloudflare:master.

@terinjokes
Copy link
Contributor

What environment is this?

@Xayer
Copy link
Author

Xayer commented Jul 5, 2020

What environment is this?

node 8, 10 and 12 running a vue app in development mode.

@terinjokes
Copy link
Contributor

This package doesn't support the browser, as there's a CORS policy preventing API access.

@Xayer
Copy link
Author

Xayer commented Jul 7, 2020

😞

@terinjokes terinjokes closed this Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants