Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GatewayDest: allow noWrapper mode #45

Open
wants to merge 1 commit into
base: master
from

Conversation

1 participant
@slorber
Copy link

slorber commented Mar 7, 2019

GatewayDest should be able to render components in place without the need to add a wrapper element.

My usecase for this is my GatewayDest is inside a container with align-items: space-between. Having an empty wrapper View here messes up my layout. (It's for a dynamic RN dev toolbar menu)

Also, I think not having a wrapper could be a nice default, and make react-gateway work out of the box with RN. If the user wants to wrap his dest he could still do that in userland.

But that would be a breaking change and require minimum React version to work.

@slorber

This comment has been minimized.

Copy link
Author

slorber commented Mar 7, 2019

Actually, just found out that it's possible to do this, so actually it's possible to opt-out of the wrapper from userland.
image

Still, I think it would make sense to use fragment as a default and would like your opinion on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.