Support SolidStart in autoconfig (#11478)

* Support SolidStart in autoconfig

* remove nitropack installation

* Remove nitropack installation from C3 stable as well

Author: dario-piotrowicz

.changeset/bumpy-beds-sink.md

@@ -0,0 +1,5 @@
+---
+"create-cloudflare": patch
+---
+
+Support SolidStart in `--experimental` mode

.changeset/every-swans-melt.md

@@ -0,0 +1,5 @@
+---
+"create-cloudflare": patch
+---
+
+Remove unnecessary nitropack installation

.changeset/plenty-tables-teach.md

@@ -0,0 +1,5 @@
+---
+"wrangler": minor
+---
+
+Support SolidStart in autoconfig

packages/create-cloudflare/e2e/tests/cli/cli.test.ts

@@ -555,7 +555,7 @@ describe("Create Cloudflare CLI", () => {
 					    npm create cloudflare -- --framework next -- --ts
 					    pnpm create cloudflare --framework next -- --ts
 					    Allowed Values:
-					      gatsby, svelte, docusaurus, astro, tanstack-start, angular
+					      gatsby, svelte, docusaurus, astro, tanstack-start, angular, solid
 					  --platform=<value>
 					    Whether the application should be deployed to Pages or Workers. This is only applicable for Frameworks templates that support both Pages and Workers.
 					    Allowed Values:

packages/create-cloudflare/e2e/tests/frameworks/test-config.ts

@@ -765,6 +765,34 @@ function getExperimentalFrameworkTestConfig(
 			flags: ["--style", "sass"],
 			verifyTypes: false,
 		},
+		{
+			name: "solid",
+			promptHandlers: [
+				{
+					matcher: /Which template would you like to use/,
+					input: [keys.enter],
+				},
+			],
+			flags: ["--ts"],
+			extraEnv: {
+				BEGIT_GH_API_KEY: process.env.GITHUB_TOKEN,
+			},
+			testCommitMessage: true,
+			timeout: LONG_TIMEOUT,
+			unsupportedPms: ["npm", "yarn"],
+			unsupportedOSs: ["win32"],
+			verifyDeploy: {
+				route: "/",
+				expectedText: "Hello world",
+			},
+			verifyPreview: {
+				previewArgs: ["--inspector-port=0"],
+				route: "/",
+				expectedText: "Hello world",
+			},
+			nodeCompat: true,
+			verifyTypes: false,
+		},
 	];
 }
 

packages/create-cloudflare/src/templates.ts

@@ -242,6 +242,7 @@ export function getFrameworkMap({ experimental = false }): TemplateMap {
 			astro: astroTemplate,
 			"tanstack-start": tanStackStartTemplate,
 			angular: angularTemplate,
+			solid: solidTemplate,
 		};
 	} else {
 		return {

packages/create-cloudflare/templates/solid/c3.ts

@@ -1,11 +1,10 @@
 import { logRaw, updateStatus } from "@cloudflare/cli";
-import { blue, brandColor, dim } from "@cloudflare/cli/colors";
+import { blue } from "@cloudflare/cli/colors";
 import { runFrameworkGenerator } from "frameworks/index";
 import { mergeObjectProperties, transformFile } from "helpers/codemod";
 import { getWorkerdCompatibilityDate } from "helpers/compatDate";
 import { usesTypescript } from "helpers/files";
 import { detectPackageManager } from "helpers/packageManagers";
-import { installPackages } from "helpers/packages";
 import * as recast from "recast";
 import type { TemplateConfig } from "../../src/templates";
 import type { C3Context } from "types";
@@ -21,13 +20,6 @@ const generate = async (ctx: C3Context) => {
 };
 
 const configure = async (ctx: C3Context) => {
-	const packages = ["nitropack"];
-	await installPackages(packages, {
-		dev: true,
-		startText: "Installing nitro module `nitropack`",
-		doneText: `${brandColor("installed")} ${dim(`via \`${npm} install\``)}`,
-	});
-
 	usesTypescript(ctx);
 	const filePath = `app.config.${usesTypescript(ctx) ? "ts" : "js"}`;
 

packages/wrangler/src/autoconfig/frameworks/get-framework.ts

@@ -1,5 +1,6 @@
 import { Angular } from "./angular";
 import { Astro } from "./astro";
+import { SolidStart } from "./solid-start";
 import { Static } from "./static";
 import { SvelteKit } from "./sveltekit";
 import { TanstackStart } from "./tanstack";
@@ -18,6 +19,8 @@ export function getFramework(detectedFramework?: {
 			return new TanstackStart(detectedFramework.name);
 		case "angular":
 			return new Angular(detectedFramework.name);
+		case "solid-start":
+			return new SolidStart(detectedFramework.name);
 		default:
 			return new Static(detectedFramework?.name);
 	}

packages/wrangler/src/autoconfig/frameworks/solid-start.ts

@@ -0,0 +1,66 @@
+import { updateStatus } from "@cloudflare/cli";
+import { blue } from "@cloudflare/cli/colors";
+import * as recast from "recast";
+import { getDevCompatibilityDate } from "../../utils/compatibility-date";
+import { mergeObjectProperties, transformFile } from "../c3-vendor/codemod";
+import { usesTypescript } from "../uses-typescript";
+import { Framework } from ".";
+import type { ConfigurationOptions, ConfigurationResults } from ".";
+
+export class SolidStart extends Framework {
+	async configure({
+		projectPath,
+		dryRun,
+	}: ConfigurationOptions): Promise<ConfigurationResults> {
+		if (!dryRun) {
+			const filePath = `app.config.${usesTypescript(projectPath) ? "ts" : "js"}`;
+
+			const compatDate = getDevCompatibilityDate(undefined);
+
+			updateStatus(`Updating configuration in ${blue(filePath)}`);
+
+			transformFile(filePath, {
+				visitCallExpression: function (n) {
+					const callee = n.node.callee as recast.types.namedTypes.Identifier;
+					if (callee.name !== "defineConfig") {
+						return this.traverse(n);
+					}
+
+					const b = recast.types.builders;
+					mergeObjectProperties(
+						n.node.arguments[0] as recast.types.namedTypes.ObjectExpression,
+						[
+							b.objectProperty(
+								b.identifier("server"),
+								b.objectExpression([
+									// preset: "cloudflare_module"
+									b.objectProperty(
+										b.identifier("preset"),
+										b.stringLiteral("cloudflare_module")
+									),
+									b.objectProperty(
+										b.identifier("compatibilityDate"),
+										b.stringLiteral(compatDate)
+									),
+								])
+							),
+						]
+					);
+
+					return false;
+				},
+			});
+		}
+
+		return {
+			wranglerConfig: {
+				main: "./.output/server/index.mjs",
+				compatibility_flags: ["nodejs_compat"],
+				assets: {
+					binding: "ASSETS",
+					directory: "./.output/public",
+				},
+			},
+		};
+	}
+}