Commit 4688f59
authored
[wrangler] Notify user on local dev server reload (#10750)
Because we set `logRequests: false` in the miniflare options,
miniflare's "Updated and ready" message is suppressed for all
local server reloads.
This change ensures users are notified when the local server is ready
after a reload event, instead of only seeing "Reloading local server..."
with no confirmation of success.
This also changes the `waitForReload` e2e helper function to check
for the reload success message rather than the
"Reloading local server..." message for a stronger guarantee that
reloads have completed.
To accommodate the stronger wait condition, we set the
default timeout of `waitForReload` to 15 seconds to
match the `waitForReady` timeout.1 parent 3455912 commit 4688f59
File tree
4 files changed
+13
-2
lines changed- .changeset
- packages/wrangler
- e2e/helpers
- src/api/startDevWorker
4 files changed
+13
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
306 | 306 | | |
307 | 307 | | |
308 | 308 | | |
| 309 | + | |
| 310 | + | |
309 | 311 | | |
310 | 312 | | |
311 | 313 | | |
| |||
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
| 213 | + | |
| 214 | + | |
213 | 215 | | |
214 | 216 | | |
215 | 217 | | |
| |||
0 commit comments