Skip to content

Commit 4688f59

Browse files
authored
[wrangler] Notify user on local dev server reload (#10750)
Because we set `logRequests: false` in the miniflare options, miniflare's "Updated and ready" message is suppressed for all local server reloads. This change ensures users are notified when the local server is ready after a reload event, instead of only seeing "Reloading local server..." with no confirmation of success. This also changes the `waitForReload` e2e helper function to check for the reload success message rather than the "Reloading local server..." message for a stronger guarantee that reloads have completed. To accommodate the stronger wait condition, we set the default timeout of `waitForReload` to 15 seconds to match the `waitForReady` timeout.
1 parent 3455912 commit 4688f59

File tree

4 files changed

+13
-2
lines changed

4 files changed

+13
-2
lines changed

.changeset/pretty-llamas-grin.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"wrangler": patch
3+
---
4+
5+
Notify user on local dev server reload.
6+
7+
When running `wrangler dev`, the local server suppresses Miniflare's reload messages to prevent duplicate log entries from the proxy and user workers. This update adds a reload complete message so users know their changes were applied, instead of only seeing "Reloading local server...".

packages/wrangler/e2e/helpers/wrangler.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ export class WranglerLongLivedCommand extends LongLivedCommand {
4343
return match.groups as { url: string };
4444
}
4545

46-
async waitForReload(readTimeout = 5_000): Promise<void> {
46+
async waitForReload(readTimeout = 15_000): Promise<void> {
4747
await this.readUntil(
48-
/Detected changes, restarted server|Reloading local server\.\.\./,
48+
/Detected changes, restarted server|Local server updated and ready/,
4949
readTimeout
5050
);
5151
}

packages/wrangler/src/api/startDevWorker/LocalRuntimeController.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,8 @@ export class LocalRuntimeController extends RuntimeController {
306306
logger.log(chalk.dim("⎔ Reloading local server..."));
307307

308308
await this.#mf.setOptions(options);
309+
310+
logger.log(chalk.dim("⎔ Local server updated and ready"));
309311
}
310312
// All asynchronous `Miniflare` methods will wait for all `setOptions()`
311313
// calls to complete before resolving. To ensure we get the `url` and

packages/wrangler/src/api/startDevWorker/MultiworkerRuntimeController.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,8 @@ export class MultiworkerRuntimeController extends LocalRuntimeController {
210210
logger.log(chalk.dim("⎔ Reloading local server..."));
211211

212212
await this.#mf.setOptions(mergedMfOptions);
213+
214+
logger.log(chalk.dim("⎔ Local server updated and ready"));
213215
}
214216

215217
// All asynchronous `Miniflare` methods will wait for all `setOptions()`

0 commit comments

Comments
 (0)