modernize kv-asset-handler so that we can test is in Node 22+ (#11348)

* modernize kv-asset-handler so that we can test is in Node 22+

* suggestion from Vic

* fix exports on the kv-asset-handler package.json

* move kv-asset-handler tests back into main test run

* only test on Node 22

Node 20 has been in Maintenance for over a year and will become end of life in April 2026.
Node 22 entered Maintenance in October and is arguably the most stable and supported version right now.

* also test packages on Node 20 and 24

* really don't run interactive-dev tests on Windows

* remove redundant service-worker-mock

* wait for the old port to be closed

* Add resilience to reading and writing the dev registry files

* give prisma tests a bit longer to run

Author: petebacondarwin

.changeset/cruel-hairs-flow.md

@@ -0,0 +1,5 @@
+---
+"@cloudflare/kv-asset-handler": patch
+---
+
+refactor to generate ESM modules and support Node 22+

.changeset/green-poems-lie.md

@@ -0,0 +1,5 @@
+---
+"miniflare": patch
+---
+
+Add resilience to reading and writing the dev registry files

.github/actions/install-dependencies/action.yml

@@ -1,9 +1,10 @@
 name: "Install Dependencies"
 description: "Install dependencies, fetching from cache when possible"
 inputs:
+  # We run all jobs on Node.js 22 by default, as this is the most stable and supported version right now.
   node-version:
     description: the version of Node.js to install
-    default: 20.19.1
+    default: 22
   pnpm-filters:
     description: space-separated list of pnpm filters to apply (e.g., "wrangler miniflare")
     default: ""

.github/workflows/c3-e2e.yml

@@ -6,10 +6,6 @@ on:
 permissions:
   contents: read
 
-env:
-  # TODO: switch back to 20.x onces node@20.x includes a fix for https://github.com/nodejs/node/issues/57869
-  NODE_VERSION: 22
-
 jobs:
   e2e:
     # Runs the non-frameworks C3 E2E tests on all supported operating systems and package managers.
@@ -53,7 +49,6 @@ jobs:
         if: steps.changes.outputs.everything_but_markdown == 'true'
         uses: ./.github/actions/install-dependencies
         with:
-          node-version: ${{ env.NODE_VERSION }}
           turbo-api: ${{ secrets.TURBO_API }}
           turbo-team: ${{ secrets.TURBO_TEAM }}
           turbo-token: ${{ secrets.TURBO_TOKEN }}

.github/workflows/changesets.yml

@@ -10,9 +10,6 @@ permissions:
   contents: read
   # note: no write permissions are needed since the workflow uses GH_ACCESS_TOKEN instead of GITHUB_TOKEN
 
-env:
-  NODE_VERSION: 24
-
 jobs:
   release:
     if: ${{ github.repository_owner == 'cloudflare' }}
@@ -30,7 +27,6 @@ jobs:
       - name: Install Dependencies
         uses: ./.github/actions/install-dependencies
         with:
-          node-version: ${{ env.NODE_VERSION }}
           turbo-api: ${{ secrets.TURBO_API }}
           turbo-team: ${{ secrets.TURBO_TEAM }}
           turbo-token: ${{ secrets.TURBO_TOKEN }}

.github/workflows/deploy-pages-previews.yml

@@ -43,8 +43,6 @@ jobs:
 
       - name: Install Dependencies
         uses: ./.github/actions/install-dependencies
-        with:
-          node-version: 22
 
       - name: Build tools and libraries
         run: pnpm run build

.github/workflows/e2e.yml

@@ -20,14 +20,10 @@ jobs:
         include:
           - os: macos-latest
             description: v20, macOS
-            node: 20.19.1
           - os: windows-latest
             description: v20, Windows
-            node: 20.19.1
-            # we need to use an amd image to run the containers tests, since we build for linux/amd64
           - os: ubuntu-latest
             description: v20, Linux
-            node: 20.19.1
 
     runs-on: ${{ matrix.os }}
     steps:
@@ -47,7 +43,6 @@ jobs:
         if: steps.changes.outputs.everything_but_markdown == 'true'
         uses: ./.github/actions/install-dependencies
         with:
-          node-version: ${{ matrix.node }}
           turbo-api: ${{ secrets.TURBO_API }}
           turbo-team: ${{ secrets.TURBO_TEAM }}
           turbo-token: ${{ secrets.TURBO_TOKEN }}
@@ -97,15 +92,11 @@ jobs:
       matrix:
         include:
           - os: macos-latest
-            description: v20, macOS
-            node: 20.19.1
+            description: macOS
           - os: windows-latest
-            description: v20, Windows
-            node: 20.19.1
-            # we need to use an amd image to run the containers tests, since we build for linux/amd64
+            description: Windows
           - os: ubuntu-latest
-            description: v20, Linux
-            node: 20.19.1
+            description: Linux
     runs-on: ${{ matrix.os }}
     steps:
       - name: Checkout Repo
@@ -124,7 +115,6 @@ jobs:
         if: steps.changes.outputs.everything_but_markdown == 'true'
         uses: ./.github/actions/install-dependencies
         with:
-          node-version: ${{ matrix.node }}
           turbo-api: ${{ secrets.TURBO_API }}
           turbo-team: ${{ secrets.TURBO_TEAM }}
           turbo-token: ${{ secrets.TURBO_TOKEN }}

.github/workflows/prerelease.yml

@@ -35,7 +35,6 @@ jobs:
           turbo-team: ${{ secrets.TURBO_TEAM }}
           turbo-token: ${{ secrets.TURBO_TOKEN }}
           turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
-          node-version: 22
 
       - run: echo ${{ github.head_ref }}
 

.github/workflows/test-and-check.yml

@@ -75,7 +75,7 @@ jobs:
   test:
     timeout-minutes: 45
     concurrency:
-      group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os }}-${{ matrix.node_version }}-test
+      group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.os }}-test
       cancel-in-progress: true
 
     name: ${{ format('Tests ({0})', matrix.description) }}
@@ -85,16 +85,10 @@ jobs:
         include:
           - os: macos-latest
             description: macOS
-            node_version: 20.19.1
           - os: ubuntu-latest
             description: Linux
-            node_version: 20.19.1
           - os: windows-latest
             description: Windows
-            node_version: 20.19.1
-          - os: ubuntu-latest
-            description: v22, Linux
-            node_version: 22
 
     runs-on: ${{ matrix.os }}
     steps:
@@ -103,7 +97,8 @@ jobs:
         with:
           fetch-depth: 1
 
-      - uses: dorny/paths-filter@v3
+      - name: Filter changed paths
+        uses: dorny/paths-filter@v3
         id: changes
         with:
           filters: |
@@ -118,7 +113,6 @@ jobs:
           turbo-team: ${{ secrets.TURBO_TEAM }}
           turbo-token: ${{ secrets.TURBO_TOKEN }}
           turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
-          node-version: ${{ matrix.node_version }}
 
       - name: Bump package versions
         if: steps.changes.outputs.everything_but_markdown == 'true'
@@ -139,25 +133,14 @@ jobs:
         # We are running the package tests first be able to get early feedback on changes.
         # There is no point in running the fixtures if a package is broken.
         if: steps.changes.outputs.everything_but_markdown == 'true'
-        run: pnpm run test:ci --log-order=stream --concurrency=1 --filter="./packages/*" --filter="!@cloudflare/kv-asset-handler"
+        run: pnpm run test:ci --log-order=stream --concurrency=1 --filter="./packages/*"
         env:
           NODE_OPTIONS: "--max_old_space_size=8192"
           WRANGLER_LOG_PATH: ${{ runner.temp }}/wrangler-debug-logs/
           TEST_REPORT_PATH: ${{ runner.temp }}/test-report/packages/index.html
           CI_OS: ${{ matrix.description }}
           NODE_DEBUG: "@cloudflare:vite-plugin"
 
-      - name: Run tests (kv-asset-handler only)
-        # kv-asset-handler tests don't work on Node.js 22
-        # TODO: put this back in the main packages test run when https://github.com/cloudflare/workers-sdk/pull/11348 is merged
-        if: steps.changes.outputs.everything_but_markdown == 'true' && matrix.node_version != '22'
-        run: pnpm run test:ci --log-order=stream --filter="@cloudflare/kv-asset-handler"
-        env:
-          NODE_OPTIONS: "--max_old_space_size=8192"
-          WRANGLER_LOG_PATH: ${{ runner.temp }}/wrangler-debug-logs/
-          TEST_REPORT_PATH: ${{ runner.temp }}/test-report/kv-asset-handler/index.html
-          CI_OS: ${{ matrix.description }}
-
       - name: Run tests (vite-plugin playgrounds)
         if: steps.changes.outputs.everything_but_markdown == 'true'
         run: pnpm run test:ci --log-order=stream --filter="@vite-plugin-cloudflare/playground"
@@ -183,5 +166,56 @@ jobs:
         if: always()
         uses: actions/upload-artifact@v4
         with:
-          name: turbo-runs-${{ matrix.os }}-${{ matrix.node_version }}
+          name: turbo-runs-${{ matrix.os }}
           path: .turbo/runs
+
+  # This job runs the main packages' tests on other supported Node.js versions to ensure compatibility.
+  test-other-node-versions:
+    timeout-minutes: 45
+    runs-on: ubuntu-latest
+    concurrency:
+      group: ${{ github.workflow }}-${{ github.ref }}-${{ matrix.node_version }}-test-other-node-versions
+      cancel-in-progress: true
+    name: ${{ format('Tests ({0})', matrix.description) }}
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - { node_version: 20, description: "Node 20" }
+          - { node_version: 24, description: "Node 24" }
+
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 1
+
+      - name: Filter changed paths
+        uses: dorny/paths-filter@v3
+        id: changes
+        with:
+          filters: |
+            everything_but_markdown:
+              - '!**/*.md'
+
+      - name: Install Dependencies
+        if: steps.changes.outputs.everything_but_markdown == 'true'
+        uses: ./.github/actions/install-dependencies
+        with:
+          node-version: ${{ matrix.node_version }}
+          turbo-api: ${{ secrets.TURBO_API }}
+          turbo-team: ${{ secrets.TURBO_TEAM }}
+          turbo-token: ${{ secrets.TURBO_TOKEN }}
+          turbo-signature: ${{ secrets.TURBO_REMOTE_CACHE_SIGNATURE_KEY }}
+
+      - name: Run tests (packages)
+        # We are running the package tests first be able to get early feedback on changes.
+        # There is no point in running the fixtures if a package is broken.
+        if: steps.changes.outputs.everything_but_markdown == 'true'
+        run: pnpm run test:ci --log-order=stream --concurrency=1 --filter="./packages/*"
+        env:
+          NODE_OPTIONS: "--max_old_space_size=8192"
+          WRANGLER_LOG_PATH: ${{ runner.temp }}/wrangler-debug-logs/
+          TEST_REPORT_PATH: ${{ runner.temp }}/test-report/packages/index.html
+          CI_OS: ${{ matrix.description }}
+          NODE_DEBUG: "@cloudflare:vite-plugin"