Support internal-only undocumented cross_account_grant service binding property (#11335)

* Support internal-only undocumented `cross_account_grant` service binding property

* Update .changeset/tiny-melons-take.md

Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>

* replace @ts-ignore with @ts-expect-error

---------

Co-authored-by: Victor Berchet <victor@suumit.com>
Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>

Author: 3 people

.changeset/tiny-melons-take.md

@@ -0,0 +1,5 @@
+---
+"wrangler": minor
+---
+
+Support internal-only undocumented `cross_account_grant` service binding property

packages/workers-utils/src/types.ts

@@ -92,6 +92,7 @@ export type WorkerMetadataBinding =
 			service: string;
 			environment?: string;
 			entrypoint?: string;
+			cross_account_grant?: string;
 	  }
 	| { type: "analytics_engine"; name: string; dataset?: string }
 	| {

packages/workers-utils/src/worker.ts

@@ -256,6 +256,7 @@ export interface CfService {
 	entrypoint?: string;
 	props?: Record<string, unknown>;
 	remote?: boolean;
+	cross_account_grant?: string;
 }
 
 export interface CfVpcService {

packages/wrangler/src/__tests__/deploy.test.ts

@@ -10722,6 +10722,50 @@ addEventListener('fetch', event => {});`
 				expect(std.err).toMatchInlineSnapshot(`""`);
 				expect(std.warn).toMatchInlineSnapshot(`""`);
 			});
+
+			it("should support the internal and non-public facing cross_account_grant service binding field", async () => {
+				writeWranglerConfig({
+					services: [
+						{
+							binding: "FOO",
+							service: "foo-service",
+							// @ts-expect-error - cross_account_gran is purposely not included in the config types (since it is an internal-only feature)
+							cross_account_grant: "grant-service",
+						},
+					],
+				});
+				writeWorkerSource();
+				mockSubDomainRequest();
+				mockUploadWorkerRequest({
+					expectedBindings: [
+						{
+							cross_account_grant: "grant-service",
+							name: "FOO",
+							service: "foo-service",
+							type: "service",
+						},
+					],
+				});
+
+				await runWrangler("deploy index.js");
+				expect(std.out).toMatchInlineSnapshot(`
+					"
+					 ⛅️ wrangler x.x.x
+					──────────────────
+					Total Upload: xx KiB / gzip: xx KiB
+					Worker Startup Time: 100 ms
+					Your Worker has access to the following bindings:
+					Binding                    Resource
+					env.FOO (foo-service)      Worker
+
+					Uploaded test-name (TIMINGS)
+					Deployed test-name triggers (TIMINGS)
+					  https://test-name.test-sub-domain.workers.dev
+					Current Version ID: Galaxy-Class"
+				`);
+				expect(std.err).toMatchInlineSnapshot(`""`);
+				expect(std.warn).toMatchInlineSnapshot(`""`);
+			});
 		});
 
 		describe("[analytics_engine_datasets]", () => {

packages/wrangler/src/deploy/deploy.ts

@@ -913,6 +913,7 @@ See https://developers.cloudflare.com/workers/platform/compatibility-dates for m
 					props.config
 				);
 			}
+
 			workerBundle = createWorkerUploadForm(worker);
 
 			await ensureQueuesExistByConfig(config);

packages/wrangler/src/deployment-bundle/create-worker-upload-form.ts

@@ -305,11 +305,19 @@ export function createWorkerUploadForm(
 	});
 
 	bindings.services?.forEach(
-		({ binding, service, environment, entrypoint, props }) => {
+		({
+			binding,
+			service,
+			environment,
+			entrypoint,
+			props,
+			cross_account_grant,
+		}) => {
 			metadataBindings.push({
 				name: binding,
 				type: "service",
 				service,
+				cross_account_grant,
 				...(environment && { environment }),
 				...(entrypoint && { entrypoint }),
 				...(props && { props }),