fix(create-cloudflare): install dependencies without --legacy-peer-deps (#11483)

* fix(create-cloudflare): install dependencies without --legacy-peer-deps

* add changeset

Author: edmundhung

.changeset/wild-papers-own.md

@@ -0,0 +1,6 @@
+---
+"create-cloudflare": patch
+"wrangler": patch
+---
+
+stop running `npm install` with `--legacy-peer-deps` flag when setting up a project

packages/create-cloudflare/src/helpers/__tests__/packages.test.ts

@@ -34,7 +34,7 @@ describe("Package Helpers", () => {
 			await npmInstall(createTestContext());
 
 			expect(vi.mocked(runCommand)).toHaveBeenCalledWith(
-				["npm", "install", "--legacy-peer-deps"],
+				["npm", "install"],
 				expect.anything(),
 			);
 		});
@@ -58,11 +58,7 @@ describe("Package Helpers", () => {
 		};
 
 		const cases: TestCase[] = [
-			{
-				pm: "npm",
-				initialArgs: ["npm", "install"],
-				additionalArgs: ["--legacy-peer-deps"],
-			},
+			{ pm: "npm", initialArgs: ["npm", "install"] },
 			{ pm: "pnpm", initialArgs: ["pnpm", "install"] },
 			{ pm: "bun", initialArgs: ["bun", "add"] },
 			{ pm: "yarn", initialArgs: ["yarn", "add"] },
@@ -107,11 +103,7 @@ describe("Package Helpers", () => {
 		);
 
 		const devCases: TestCase[] = [
-			{
-				pm: "npm",
-				initialArgs: ["npm", "install", "--save-dev"],
-				additionalArgs: ["--legacy-peer-deps"],
-			},
+			{ pm: "npm", initialArgs: ["npm", "install", "--save-dev"] },
 			{ pm: "pnpm", initialArgs: ["pnpm", "install", "--save-dev"] },
 			{ pm: "bun", initialArgs: ["bun", "add", "-d"] },
 			{ pm: "yarn", initialArgs: ["yarn", "add", "-D"] },
@@ -165,7 +157,7 @@ describe("Package Helpers", () => {
 		await installWrangler();
 
 		expect(vi.mocked(runCommand)).toHaveBeenCalledWith(
-			["npm", "install", "--save-dev", "wrangler@latest", "--legacy-peer-deps"],
+			["npm", "install", "--save-dev", "wrangler@latest"],
 			expect.anything(),
 		);
 	});

packages/create-cloudflare/src/helpers/packages.ts

@@ -51,22 +51,10 @@ export const installPackages = async (
 			break;
 	}
 
-	await runCommand(
-		[
-			npm,
-			cmd,
-			...(saveFlag ? [saveFlag] : []),
-			...packages,
-			// Add --legacy-peer-deps so that installing Wrangler v4 doesn't case issues with
-			// frameworks that haven't updated their peer dependency for Wrangler v4
-			// TODO: Remove this once Wrangler v4 has been released and framework templates are updated
-			...(npm === "npm" ? ["--legacy-peer-deps"] : []),
-		],
-		{
-			...config,
-			silent: true,
-		},
-	);
+	await runCommand([npm, cmd, ...(saveFlag ? [saveFlag] : []), ...packages], {
+		...config,
+		silent: true,
+	});
 
 	if (npm === "npm") {
 		// Npm install will update the package.json with a caret-range rather than the exact version/range we asked for.
@@ -103,17 +91,11 @@ export const npmInstall = async (ctx: C3Context) => {
 
 	const { npm } = detectPackageManager();
 
-	await runCommand(
-		// Add --legacy-peer-deps so that installing Wrangler v4 doesn't case issues with
-		// frameworks that haven't updated their peer dependency for Wrangler v4
-		// TODO: Remove this once Wrangler v4 has been released and framework templates are updated
-		[npm, "install", ...(npm === "npm" ? ["--legacy-peer-deps"] : [])],
-		{
-			silent: true,
-			startText: "Installing dependencies",
-			doneText: `${brandColor("installed")} ${dim(`via \`${npm} install\``)}`,
-		},
-	);
+	await runCommand([npm, "install"], {
+		silent: true,
+		startText: "Installing dependencies",
+		doneText: `${brandColor("installed")} ${dim(`via \`${npm} install\``)}`,
+	});
 };
 
 type NpmInfoResponse = {

packages/wrangler/src/autoconfig/c3-vendor/packages.ts

@@ -70,22 +70,10 @@ export const installPackages = async (
 			break;
 	}
 
-	await runCommand(
-		[
-			type,
-			cmd,
-			...(saveFlag ? [saveFlag] : []),
-			...packages,
-			// Add --legacy-peer-deps so that installing Wrangler v4 doesn't case issues with
-			// frameworks that haven't updated their peer dependency for Wrangler v4
-			// TODO: Remove this once Wrangler v4 has been released and framework templates are updated
-			...(type === "npm" ? ["--legacy-peer-deps"] : []),
-		],
-		{
-			...config,
-			silent: true,
-		}
-	);
+	await runCommand([type, cmd, ...(saveFlag ? [saveFlag] : []), ...packages], {
+		...config,
+		silent: true,
+	});
 
 	if (type === "npm") {
 		// Npm install will update the package.json with a caret-range rather than the exact version/range we asked for.