[wrangler] Notify user on local dev server reload#10750
Merged
petebacondarwin merged 1 commit intocloudflare:mainfrom Dec 23, 2025
Merged
[wrangler] Notify user on local dev server reload#10750petebacondarwin merged 1 commit intocloudflare:mainfrom
petebacondarwin merged 1 commit intocloudflare:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 9bf2824 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
987f6b8 to
5d14966
Compare
petebacondarwin
approved these changes
Nov 13, 2025
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
LGTM if the CI agrees
5d14966 to
ed593b6
Compare
Because we set `logRequests: false` in the miniflare options, miniflare's "Updated and ready" message is suppressed for all local server reloads. This change ensures users are notified when the local server is ready after a reload event, instead of only seeing "Reloading local server..." with no confirmation of success. This also changes the `waitForReload` e2e helper function to check for the reload success message rather than the "Reloading local server..." message for a stronger guarantee that reloads have completed. To accommodate the stronger wait condition, we set the default timeout of `waitForReload` to 15 seconds to match the `waitForReady` timeout.
ed593b6 to
9bf2824
Compare
Merged
AmirSa12
pushed a commit
to AmirSa12/workers-sdk
that referenced
this pull request
Jan 5, 2026
Because we set `logRequests: false` in the miniflare options, miniflare's "Updated and ready" message is suppressed for all local server reloads. This change ensures users are notified when the local server is ready after a reload event, instead of only seeing "Reloading local server..." with no confirmation of success. This also changes the `waitForReload` e2e helper function to check for the reload success message rather than the "Reloading local server..." message for a stronger guarantee that reloads have completed. To accommodate the stronger wait condition, we set the default timeout of `waitForReload` to 15 seconds to match the `waitForReady` timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently,
wrangler devdoes not notify the user that reloads have completed for local servers. Users only see "Reloading local server...", which might cause confusion for users expecting a ready message.This change adds a log message to inform users the local server is ready after reload.
Implementation Details
Because we set
logRequests: falsein the miniflare options, miniflare's "Updated and ready" message is suppressed for all local server reloads.This is done to avoid duplicate log entries from the proxy and user workers, so it seems simplest for
wranglerto provide its own reload complete message after awaiting the miniflare options change.This also changes the
waitForReloade2e helper function to check for the reload success message rather than the"Updating local server..." message for a stronger guarantee that reloads have completed.
To accommodate the stronger wait condition, we set the default timeout of
waitForReloadto 15 seconds to match thewaitForReadytimeout.