Skip to content

Add way to configure image registries without secret store integration for fedramp_high#11196

Merged
nikitassharma merged 8 commits intomainfrom
emily/registries-do
Dec 17, 2025
Merged

Add way to configure image registries without secret store integration for fedramp_high#11196
nikitassharma merged 8 commits intomainfrom
emily/registries-do

Conversation

@emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Nov 6, 2025

Normally, we want to use secret-store to store credentials for image registries.

However, secret store is not available in fedramp_moderate, and containers will be. If FRH is detected, wrangler will not create a secret store but rather pass the secret directly to the container control plane to handle.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: FRH for containers not currently documented
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not in v3

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

🦋 Changeset detected

Latest commit: 913738a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 6, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11196

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11196

miniflare

npm i https://pkg.pr.new/miniflare@11196

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11196

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11196

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11196

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11196

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11196

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11196

wrangler

npm i https://pkg.pr.new/wrangler@11196

commit: 913738a

@nikitassharma nikitassharma changed the title Add way to configure image registries without secret store integration, and add fedramp_moderate Add way to configure image registries without secret store integration for fedramp_high Dec 17, 2025
@claude
Copy link
Contributor

claude bot commented Dec 17, 2025

Claude finished @emily-shen's task —— View job


Changeset Review

Reviewing changeset file: .changeset/evil-paws-check.md

  • Read changeset guidelines
  • Read changeset file
  • Validate version types
  • Check changelog quality
  • Check for markdown header violations
  • Provide findings

⚠️ Issues found

Changelog Quality Issues:

The changeset description is too brief and doesn't follow the guidelines for new features (minor version bumps). According to .changeset/README.md:

  1. Missing Usage Example: For new features, the guidelines require "a brief usage example" to help users understand how to use the new functionality. The current description only explains what changed internally but doesn't show users how to actually configure registries for FedRAMP High environments.

  2. Lacks User-Facing Context: The description focuses on implementation details ("registry credentials are encrypted by the container platform") rather than explaining:

    • What the new capability enables for users
    • How users would configure registries in FedRAMP High environments
    • Any new commands, flags, or configuration options

Suggested Improvement:

The changeset should include:

  • A clear explanation of what users can now do
  • A concrete example showing how to configure image registries for FedRAMP High
  • Any relevant command syntax or configuration format

Example format:

Add support for configuring image registries in FedRAMP High environments

You can now configure container image registries in FedRAMP High environments. When deploying to a FedRAMP High region, wrangler will automatically send registry credentials directly to the container control plane instead of using the secret store (which is not available in FedRAMP High).

Usage example showing the command or configuration would go here.

No issues with:

  • ✅ Version types (both minor for new feature, no major for wrangler)
  • ✅ Markdown headers (no h1/h2/h3 headers used)
  • ✅ Package coverage (both affected packages listed)

@nikitassharma nikitassharma marked this pull request as ready for review December 17, 2025 16:28
@nikitassharma nikitassharma requested review from a team as code owners December 17, 2025 16:28
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 17, 2025
@nikitassharma nikitassharma merged commit 171cfd9 into main Dec 17, 2025
48 of 50 checks passed
@nikitassharma nikitassharma deleted the emily/registries-do branch December 17, 2025 18:24
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 17, 2025
AmirSa12 pushed a commit to AmirSa12/workers-sdk that referenced this pull request Jan 5, 2026
…n for `fedramp_high` (cloudflare#11196)

* Fix nits from cloudflare#10605

* non-secret-store mode

* update containers api client

* clean up fedramp region code

* add tests

* changeset

* containers-shared minor

* prettify

---------

Co-authored-by: Nikita Sharma <nsharma@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants