Removes duplicate module warnings when vendoring Python packages#11284
Merged
Removes duplicate module warnings when vendoring Python packages#11284
Conversation
🦋 Changeset detectedLatest commit: 5268b77 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
danlapid
approved these changes
Nov 14, 2025
Contributor
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
c46c66f to
301e811
Compare
petebacondarwin
approved these changes
Nov 17, 2025
Contributor
|
Yeah calling |
301e811 to
c63160e
Compare
c63160e to
d615b89
Compare
d615b89 to
36e9db0
Compare
Contributor
Author
|
@petebacondarwin Rebased, hopefully now this is mergeable 🙏 |
36e9db0 to
95e5823
Compare
95e5823 to
5268b77
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrangler would output "Ignoring duplicate module" for each .txt file inside python_modules. This PR fixes this.
Turns out that this was happening because parseRules adds some default rules.
Test Plan
Before:
After: