Skip to content

Support internal-only undocumented cross_account_grant service binding property#11335

Merged
dario-piotrowicz merged 4 commits intomainfrom
dario/cross_account_grant
Nov 27, 2025
Merged

Support internal-only undocumented cross_account_grant service binding property#11335
dario-piotrowicz merged 4 commits intomainfrom
dario/cross_account_grant

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Nov 19, 2025

A few times I heard that it would be convenient for internal projects if wrangler allowed the cross_account_grant setting to be set to service bindings, so that's what this PR is doing.

This is not intended for external usage, thus I didn't include it in the json schema (whoever uses will likely get a warning from their IDE but besides that everything should work perfectly fine).


@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2025

🦋 Changeset detected

Latest commit: 95bf666

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 19, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11335

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11335

miniflare

npm i https://pkg.pr.new/miniflare@11335

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11335

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11335

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11335

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11335

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11335

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11335

wrangler

npm i https://pkg.pr.new/wrangler@11335

commit: 95bf666

@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main dario/cross_account_grant might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11335
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@dario-piotrowicz dario-piotrowicz force-pushed the dario/cross_account_grant branch 2 times, most recently from cf327e1 to 2359f16 Compare November 26, 2025 15:59
@vicb vicb force-pushed the dario/cross_account_grant branch 2 times, most recently from 1266f5c to 5a5e23e Compare November 26, 2025 19:50
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this didn't need more plumbing!

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 27, 2025
dario-piotrowicz and others added 2 commits November 27, 2025 13:17
Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>
@dario-piotrowicz dario-piotrowicz merged commit c47ad11 into main Nov 27, 2025
32 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/cross_account_grant branch November 27, 2025 14:43
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants