Use detected framework names in autoconfig#11366
Conversation
🦋 Changeset detectedLatest commit: aafe97c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>
|
|
||
| export function getFramework(id: string) { | ||
| export function getFramework(id?: string, name?: string): Framework { | ||
| if (id === "astro") { |
There was a problem hiding this comment.
Yeah maybe when we have a few more options but probably not much point now. I didn't change the logic there.
There was a problem hiding this comment.
I went ahead and changed it, as I was updating the function signature
Use the
framework.namefrom build-info rather than the ID or hard-coded name. This means it displaysSvelteKitrather thansvelte-kit