Skip to content

Use detected framework names in autoconfig#11366

Merged
ascorbic merged 8 commits intomainfrom
mk/wrangler/autoconfig-name
Nov 26, 2025
Merged

Use detected framework names in autoconfig#11366
ascorbic merged 8 commits intomainfrom
mk/wrangler/autoconfig-name

Conversation

@ascorbic
Copy link
Contributor

Use the framework.name from build-info rather than the ID or hard-coded name. This means it displays SvelteKit rather than svelte-kit


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not a documented feature
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: not in v3

@ascorbic ascorbic requested a review from a team as a code owner November 20, 2025 16:59
@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

🦋 Changeset detected

Latest commit: aafe97c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main mk/wrangler/autoconfig-name might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11366
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11366

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11366

miniflare

npm i https://pkg.pr.new/miniflare@11366

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11366

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11366

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11366

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11366

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11366

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11366

wrangler

npm i https://pkg.pr.new/wrangler@11366

commit: aafe97c


export function getFramework(id: string) {
export function getFramework(id?: string, name?: string): Framework {
if (id === "astro") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch (id) {...} ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah maybe when we have a few more options but probably not much point now. I didn't change the logic there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and changed it, as I was updating the function signature

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 25, 2025
@ascorbic ascorbic merged commit edf896d into main Nov 26, 2025
52 of 54 checks passed
@ascorbic ascorbic deleted the mk/wrangler/autoconfig-name branch November 26, 2025 17:15
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants