Conversation
🦋 Changeset detectedLatest commit: da7ee5e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
dario-piotrowicz
force-pushed
the
penalosa/c3-auto-tan
branch
from
ef1b6a3 to
d00c475
Compare
| function transformViteConfig(projectPath: string) { | ||
| const filePath = path.join( | ||
| projectPath, | ||
| `vite.config.${usesTypescript(projectPath) ? "ts" : "js"}` |
There was a problem hiding this comment.
Just a note, possibly something we might want consider down the line, a TS project could also have a vite.config.js file, maybe we might want to check all types? 🤔
It's just a thought, I think this might be pretty edge-case anyways 🙂
There was a problem hiding this comment.
I'm not sure that is an edge case. I'd imagine it's quite common for TypeScript projects to still have vite.config.js files. I think it needs to check both.
Support Tanstack in autoconfig experimental flow.
penalosa
force-pushed
the
penalosa/c3-auto-tan
branch
from
d00c475 to
849a4c8
Compare
dario-piotrowicz
left a comment
dario-piotrowicz
left a comment
There was a problem hiding this comment.
It still looks great to me! 😄
(besides the potentially unintentional Astro changeset)
ascorbic
left a comment
ascorbic
left a comment
There was a problem hiding this comment.
Aside from the point about the config file, this looks great. Let's get this in so we can use the codemod helper for other frameworks
3 participants
Fixes https://jira.cfdata.org/browse/DEVX-2327