Skip to content

Ensure that wrangler dev and vite dev/preview crash when we fail to create a remote proxy session#11383

Merged
dario-piotrowicz merged 11 commits intomainfrom
dario/11253/remote-bindings-failed-remote-session-fix
Nov 28, 2025
Merged

Ensure that wrangler dev and vite dev/preview crash when we fail to create a remote proxy session#11383
dario-piotrowicz merged 11 commits intomainfrom
dario/11253/remote-bindings-failed-remote-session-fix

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Nov 22, 2025

Fixes #11253

This PR makes sure that both wrangler and the vite-plugin appropriately error when a remote proxy session fails to be established (instead of making requests hang for example).


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: self explanatory behavior
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: remote bindings are not present in v3

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2025

🦋 Changeset detected

Latest commit: 8767488

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Nov 22, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/11253/remote-bindings-failed-remote-session-fix branch 2 times, most recently from 01af02d to 3150fcc Compare November 24, 2025 11:33
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 24, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11383

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11383

miniflare

npm i https://pkg.pr.new/miniflare@11383

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11383

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11383

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11383

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11383

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11383

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11383

wrangler

npm i https://pkg.pr.new/wrangler@11383

commit: 8767488

@dario-piotrowicz dario-piotrowicz force-pushed the dario/11253/remote-bindings-failed-remote-session-fix branch from 3150fcc to ece6d21 Compare November 24, 2025 18:33
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review November 24, 2025 18:35
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner November 24, 2025 18:35
@dario-piotrowicz dario-piotrowicz requested a review from a team November 24, 2025 18:35
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few minor comments

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 24, 2025
@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main dario/11253/remote-bindings-failed-remote-session-fix might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11383
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@dario-piotrowicz dario-piotrowicz force-pushed the dario/11253/remote-bindings-failed-remote-session-fix branch from 0cf1c84 to 0af9d63 Compare November 25, 2025 11:53
@dario-piotrowicz dario-piotrowicz marked this pull request as draft November 25, 2025 21:29
@dario-piotrowicz dario-piotrowicz force-pushed the dario/11253/remote-bindings-failed-remote-session-fix branch 3 times, most recently from 297f94e to b7ab666 Compare November 26, 2025 21:53
@dario-piotrowicz dario-piotrowicz force-pushed the dario/11253/remote-bindings-failed-remote-session-fix branch from b7ab666 to e0b7e93 Compare November 28, 2025 01:23
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review November 28, 2025 11:02
`${errorSpy.mock.calls?.[0]?.[0]}`
// Windows gets a different marker for ✘, so let's normalize it here
// so that this test can be platform independent
.replaceAll("✘", "X")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it would be good to have a common helper for that - could be addressed in a follow up PR

@dario-piotrowicz dario-piotrowicz force-pushed the dario/11253/remote-bindings-failed-remote-session-fix branch from 4143b2a to 8767488 Compare November 28, 2025 12:30
@dario-piotrowicz dario-piotrowicz merged commit 1d685cb into main Nov 28, 2025
27 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/11253/remote-bindings-failed-remote-session-fix branch November 28, 2025 13:48
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

R2 remote bindings hangs when the bucket does not exist

2 participants