Ensure that wrangler dev and vite dev/preview crash when we fail to create a remote proxy session#11383
Conversation
🦋 Changeset detectedLatest commit: 8767488 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
01af02d to
3150fcc
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
3150fcc to
ece6d21
Compare
packages/wrangler/src/__tests__/dev/remote-bindings-errors.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/dev/remote-bindings-errors.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/dev/remote-bindings-errors.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/dev/remote-bindings-errors.test.ts
Outdated
Show resolved
Hide resolved
vicb
left a comment
There was a problem hiding this comment.
LGTM with a few minor comments
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
0cf1c84 to
0af9d63
Compare
297f94e to
b7ab666
Compare
b7ab666 to
e0b7e93
Compare
| `${errorSpy.mock.calls?.[0]?.[0]}` | ||
| // Windows gets a different marker for ✘, so let's normalize it here | ||
| // so that this test can be platform independent | ||
| .replaceAll("✘", "X") |
There was a problem hiding this comment.
nit: it would be good to have a common helper for that - could be addressed in a follow up PR
…nnot be established an appropriate error is surfaced to the user
Co-authored-by: Victor Berchet <victor@suumit.com>
Co-authored-by: Victor Berchet <victor@suumit.com>
4143b2a to
8767488
Compare
Fixes #11253
This PR makes sure that both wrangler and the vite-plugin appropriately error when a remote proxy session fails to be established (instead of making requests hang for example).