Skip to content

Miscellaneous improvements and refactorings#11414

Merged
petebacondarwin merged 7 commits intomainfrom
pbd/misc
Dec 8, 2025
Merged

Miscellaneous improvements and refactorings#11414
petebacondarwin merged 7 commits intomainfrom
pbd/misc

Conversation

@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Nov 25, 2025

A collection of small changes:

  • add extra logging to user log-in flow for diagnosing failed login requests
  • ensure that we don't bump TypeScript accidentally - 5.9.x appears to cause typings problems with some of our packages
  • allow PWD to be passed into turbo jobs
  • simplify the workers-utils package's vitest config
  • change C3 builds so that it can import the ESM modules from workers-utils

  • Tests
    • Tests included
    • Tests not necessary because: refactoring covered by current tests
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactoring
  • Wrangler V3 Backport
    • Wrangler PR: TBD
    • Not necessary because: test and config changes not backported

@petebacondarwin petebacondarwin requested a review from a team as a code owner November 25, 2025 17:55
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

🦋 Changeset detected

Latest commit: 19f84c1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 25, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11414

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11414

miniflare

npm i https://pkg.pr.new/miniflare@11414

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11414

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11414

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11414

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11414

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11414

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11414

wrangler

npm i https://pkg.pr.new/wrangler@11414

commit: 19f84c1

@petebacondarwin petebacondarwin marked this pull request as draft November 26, 2025 07:43
@petebacondarwin petebacondarwin force-pushed the pbd/misc branch 3 times, most recently from e30778b to 2b32c10 Compare December 4, 2025 17:30
@petebacondarwin petebacondarwin marked this pull request as ready for review December 5, 2025 07:24
setupFiles: path.resolve(__dirname, "tests/vitest.setup.ts"),
globalSetup: path.resolve(__dirname, "tests/vitest.global.ts"),
reporters: ["default"],
globals: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I tried that across the repo and it failed (I have a closed PR)

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 5, 2025
@petebacondarwin petebacondarwin merged commit 41103f5 into main Dec 8, 2025
29 checks passed
@petebacondarwin petebacondarwin deleted the pbd/misc branch December 8, 2025 13:13
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants