Merged
Conversation
🦋 Changeset detectedLatest commit: 6e6db93 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
penalosa
commented
Nov 27, 2025
|
|
||
| // [alt_names] | ||
| // DNS.0 = localhost | ||
| // IP.1 = 127.0.0.1 |
Contributor
Author
There was a problem hiding this comment.
This is the key change to the included cert
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Wrangler generated self-signed certificates on the user's behalf when they requested a secure dev server but didn't provide custom certs. With this PR, we delegate through to Miniflare's implementation (using a shared cert), which cuts over 1MB from the Wrangler bundle by removing the certificate generation libraries.
I don't think this is a breaking change, since we already generate these certs on a 30 day interval and so they shouldn't be assumed to be stable.