Skip to content

fix(wrangler): prevent SQLite users error from being reported to Sentry#11467

Merged
edmundhung merged 2 commits intomainfrom
edmundhung/fix-sentry-error
Dec 10, 2025
Merged

fix(wrangler): prevent SQLite users error from being reported to Sentry#11467
edmundhung merged 2 commits intomainfrom
edmundhung/fix-sentry-error

Conversation

@edmundhung
Copy link
Member

@edmundhung edmundhung commented Nov 28, 2025

Fixes n/a.


@edmundhung edmundhung requested review from a team as code owners November 28, 2025 19:21
@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2025

🦋 Changeset detected

Latest commit: 3f432af

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main edmundhung/fix-sentry-error might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-11467
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 28, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11467

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11467

miniflare

npm i https://pkg.pr.new/miniflare@11467

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11467

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11467

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11467

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11467

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11467

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11467

wrangler

npm i https://pkg.pr.new/wrangler@11467

commit: 3f432af

@edmundhung edmundhung marked this pull request as draft December 1, 2025 11:42
@edmundhung edmundhung force-pushed the edmundhung/fix-sentry-error branch from 9b6a97c to e2af87a Compare December 2, 2025 15:21
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🤩

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 10, 2025

// Common SQLite Codes
// See https://www.sqlite.org/rescode.html#constraint
const SQLITE_RESULT_CODES = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQLITE_AUTH is also a common one thrown when users try to use functions we do not allowlist in workerd.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know. Thanks! Added in 3f432af.

@edmundhung edmundhung merged commit 235d325 into main Dec 10, 2025
39 of 41 checks passed
@edmundhung edmundhung deleted the edmundhung/fix-sentry-error branch December 10, 2025 14:01
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 10, 2025
dario-piotrowicz pushed a commit that referenced this pull request Dec 11, 2025
…ry (#11467)

* fix(wrangler): prevent SQLite users error from being reported to Sentry

* add SQLITE_AUTH to common error codes
edmundhung added a commit that referenced this pull request Dec 17, 2025
… to Sentry (#11501)

* fix(wrangler): prevent SQLite users error from being reported to Sentry

* add SQLITE_AUTH to common error codes

* fix tests
@penalosa penalosa mentioned this pull request Jan 12, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants