Skip to content

fix(wrangler): close FileHandle in wrangler d1 execute to support Node 25#11484

Merged
edmundhung merged 1 commit intomainfrom
edmundhung/fix-d1-execute-node-25-error
Dec 1, 2025
Merged

fix(wrangler): close FileHandle in wrangler d1 execute to support Node 25#11484
edmundhung merged 1 commit intomainfrom
edmundhung/fix-d1-execute-node-25-error

Conversation

@edmundhung
Copy link
Member

@edmundhung edmundhung commented Dec 1, 2025

Fixes #11468.

This fixes an error when running wrangler d1 execute on Node 25:

> npx wrangler d1 execute test --file schema.sql

 ⛅️ wrangler 4.51.0
───────────────────
Resource location: local 

Use --remote if you want to access the remote instance.

🌀 Executing on local database test (e582c621-5286-41d7-aee3-743c0b3a2302) from .wrangler/state/v3/d1:
🌀 To execute on your remote database, add a --remote flag to your wrangler command.
[Error: A FileHandle object was closed during garbage collection. This used to be allowed with a deprecation warning but is now considered an error. Please close FileHandle objects explicitly. File descriptor: 21 (schema.sql)] {
  code: 'ERR_INVALID_STATE'
}

I have tested this manually with the repo provided in #11468.


@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2025

🦋 Changeset detected

Latest commit: 4e5a8c0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Dec 1, 2025
@edmundhung edmundhung changed the title fix(wrangler): close FileHandle in to support Node 25 fix(wrangler): close FileHandle in wrangler d1 execute to support Node 25 Dec 1, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 1, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11484

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11484

miniflare

npm i https://pkg.pr.new/miniflare@11484

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11484

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11484

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11484

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11484

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11484

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11484

wrangler

npm i https://pkg.pr.new/wrangler@11484

commit: 4e5a8c0

@edmundhung edmundhung marked this pull request as ready for review December 1, 2025 16:29
@edmundhung edmundhung requested review from a team as code owners December 1, 2025 16:29
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 1, 2025
@edmundhung edmundhung merged commit 1cfae2d into main Dec 1, 2025
36 of 40 checks passed
@edmundhung edmundhung deleted the edmundhung/fix-d1-execute-node-25-error branch December 1, 2025 17:40
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 1, 2025
@petebacondarwin
Copy link
Contributor

Tested manually on Node 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

D1 execute --file crashes due to Please close FileHandle objects explicitly message

3 participants