Fix wrangler deploy failing for new workers containing environment variables or bindings

[dario-piotrowicz]

Fixes the regression introduced in #11389 present in the latest version of wrangler that causes wrangler deploy run on never deployed worker failing if they have any environment variables or bindings in their configuration.

---

• Tests
  • Tests included/updated
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bugfix
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: fix to a v4-only feature

[changeset-bot]

🦋 Changeset detected

Latest commit: 87bb3d0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dario-piotrowicz]

This seems sensible to me, but I am happy to broaden this that's preferred 🙂

[jamesopstad]

Are we confident the error code will always be 10007 for this scenario?

[WillTaylorDev]

Happy with this from the backend side of house 👍

[github-actions]

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main dario/fix-wrangler-deploy-fetch-secrets-on-new-workers might be a good starting point.

Notes:

• your PR branch should be named v3-backport-11504
• add the skip-v3-pr label to the current PR to stop this workflow from failing

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11504

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11504

miniflare

npm i https://pkg.pr.new/miniflare@11504

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11504

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11504

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11504

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11504

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11504

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11504

wrangler

npm i https://pkg.pr.new/wrangler@11504

commit: 87bb3d0

[dario-piotrowicz]

PS: I can see a few places where we check for code 10007 errors, I will open a followup PR to consolidate those, but for this PR, in order to safely fix the latest release, I'd avoid the extra unnecessary risk and just proceed with this the bugfix

[jamesopstad]

PS: I can see a few places where we check for code 10007 errors, I will open a followup PR to consolidate those, but for this PR, in order to safely fix the latest release, I'd avoid the extra unnecessary risk and just proceed with this the bugfix

Agree it's not for this PR but we should really get rid of all these magic numbers and have an object with the error codes that we can import from.

[jamesopstad]

Thanks Dario.