Conversation
🦋 Changeset detectedLatest commit: 8a3f064 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
gpanders
force-pushed
the
ganders/mtvsrouosmyx
branch
4 times, most recently
from
9fc4e2c to
74d222f
Compare
Fix a few papercuts with the new container ssh command: * Provide single-letter aliases for common SSH options (`-F` to specify a config file, `-o` to specify options, `-i` to set the private key) * Allow `-o` to be used multiple times for setting multiple options * Show the cursor when the SSH process starts. The library that Wrangler uses to draw the interactive UI (clack) hides the cursor, so it is not visible when the SSH shell starts. We need to manually make it visible. * Hard code some specific SSH options (ControlMaster, ControlPersist, UserKnownHostsFile, and StrictHostKeyChecking). These don't make sense to use with the way our SSH implementation works
gpanders
force-pushed
the
ganders/mtvsrouosmyx
branch
from
74d222f to
1ec06eb
Compare
emily-shen
approved these changes
Dec 10, 2025
nikitassharma
approved these changes
Dec 10, 2025
Member
|
LGTM :) |
gpanders
force-pushed
the
ganders/mtvsrouosmyx
branch
from
78fbd11 to
0b37791
Compare
Merged
dario-piotrowicz
pushed a commit
that referenced
this pull request
Dec 11, 2025
* Add helper function to show or hide the cursor * Watch cli directory in wrangler "dev" script * containers: ssh UX improvements Fix a few papercuts with the new container ssh command: * Provide single-letter aliases for common SSH options (`-F` to specify a config file, `-o` to specify options, `-i` to set the private key) * Allow `-o` to be used multiple times for setting multiple options * Show the cursor when the SSH process starts. The library that Wrangler uses to draw the interactive UI (clack) hides the cursor, so it is not visible when the SSH shell starts. We need to manually make it visible. * Hard code some specific SSH options (ControlMaster, ControlPersist, UserKnownHostsFile, and StrictHostKeyChecking). These don't make sense to use with the way our SSH implementation works
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CC-6563.
Fix a few papercuts with the new container ssh command:
-Fto specify a config file,-oto specify options,-ito set the private key)-oto be used multiple times for setting multiple optionscontainers ssh -- ls -l)A picture of a cute animal (not mandatory, but encouraged)