Skip to content

Properly error on Hono projects in auto-config#11647

Merged
dario-piotrowicz merged 4 commits intomainfrom
dario/DEVX-2320/autoconfig-hono
Dec 17, 2025
Merged

Properly error on Hono projects in auto-config#11647
dario-piotrowicz merged 4 commits intomainfrom
dario/DEVX-2320/autoconfig-hono

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Dec 15, 2025

Fixes https://jira.cfdata.org/browse/DEVX-2320


  • Tests
    • Tests included/updated
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tracked elsewhere
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: autoconfig is not in v3

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2025

🦋 Changeset detected

Latest commit: 1083cb9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Dec 15, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2320/autoconfig-hono branch 2 times, most recently from 37d5777 to 2a31729 Compare December 17, 2025 10:08
@claude
Copy link
Contributor

claude bot commented Dec 17, 2025

Claude finished @dario-piotrowicz's task in 37s —— View job


Changeset Review

Reviewing the changeset file according to repository guidelines.

Tasks:

  • Read changeset guidelines from .changeset/README.md
  • Read the changeset file .changeset/slow-moose-cross.md
  • Validate version type (patch/minor/major)
  • Check changelog quality and description
  • Verify no h1/h2/h3 markdown headers
  • Provide final assessment

Review Results

✅ Changeset validation passed

The changeset .changeset/slow-moose-cross.md meets all requirements:

  1. Version Type: ✅ Correctly uses patch - This is a bug fix that properly handles error cases for Hono projects
  2. Changelog Quality: ✅ Good quality - The description clearly explains:
    • What the problem is (auto-config can't reliably handle Hono projects)
    • What commands are affected (wrangler setup and wrangler deploy --x-autoconfig)
    • What the fix does (properly errors with a helpful message)
  3. Markdown Headers: ✅ No h1/h2/h3 headers present
  4. Package Coverage: ✅ Correctly targets wrangler package

The changeset follows the recommended format with a clear, imperative description that explains both the symptom and the fix. This matches the "good examples" pattern for bug fixes shown in the guidelines.

Note: I can see from the review comments that @ascorbic suggested improved wording, and @dario-piotrowicz accepted it. The current changeset content reflects that improved wording.


@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 17, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11647

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11647

miniflare

npm i https://pkg.pr.new/miniflare@11647

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11647

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11647

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11647

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11647

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11647

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11647

wrangler

npm i https://pkg.pr.new/wrangler@11647

commit: 1083cb9

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2320/autoconfig-hono branch from 2a31729 to b7e9e9b Compare December 17, 2025 10:47
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review December 17, 2025 10:48
@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner December 17, 2025 10:48
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2320/autoconfig-hono branch from b7e9e9b to 3a593dd Compare December 17, 2025 10:54
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-2320/autoconfig-hono branch from 3a593dd to 9305c1b Compare December 17, 2025 11:31
Co-authored-by: Matt Kane <m@mk.gg>
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Dec 17, 2025
@dario-piotrowicz dario-piotrowicz merged commit c0e249e into main Dec 17, 2025
50 of 53 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/DEVX-2320/autoconfig-hono branch December 17, 2025 17:41
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Dec 17, 2025
AmirSa12 pushed a commit to AmirSa12/workers-sdk that referenced this pull request Jan 5, 2026
* bump `@netlify/build-info`

* Properly error on Hono projects in auto-config

* add wrangler e2e tests for hono auto-config

* Update .changeset/slow-moose-cross.md

Co-authored-by: Matt Kane <m@mk.gg>

---------

Co-authored-by: Matt Kane <m@mk.gg>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants