Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "startDevWorker - Milestone 1"" #4535

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented Nov 30, 2023

Reverts #4531

@mrbbot mrbbot requested a review from a team as a code owner November 30, 2023 19:01
Copy link

changeset-bot bot commented Nov 30, 2023

🦋 Changeset detected

Latest commit: 94eb4f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 30, 2023

A create-cloudflare (C3) prerelease is available for testing.
You can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs//npm-package-create-cloudflare-

Note that these links will no longer work once the GitHub Actions artifact expires.

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #4535 (94eb4f3) into main (97727de) will increase coverage by 0.19%.
The diff coverage is 50.27%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4535      +/-   ##
==========================================
+ Coverage   75.25%   75.45%   +0.19%     
==========================================
  Files         226      240      +14     
  Lines       12570    12851     +281     
  Branches     3261     3309      +48     
==========================================
+ Hits         9460     9697     +237     
- Misses       3110     3154      +44     
Files Coverage Δ
packages/wrangler/src/api/index.ts 100.00% <100.00%> (ø)
.../wrangler/src/api/startDevWorker/BaseController.ts 100.00% <100.00%> (ø)
...gler/src/api/startDevWorker/NotImplementedError.ts 100.00% <100.00%> (ø)
...ckages/wrangler/src/api/startDevWorker/devtools.ts 100.00% <100.00%> (ø)
packages/wrangler/src/api/startDevWorker/types.ts 100.00% <100.00%> (ø)
packages/wrangler/src/dev.tsx 82.00% <ø> (-0.41%) ⬇️
packages/wrangler/src/https-options.ts 100.00% <100.00%> (ø)
packages/wrangler/src/api/dev.ts 82.85% <80.00%> (ø)
packages/wrangler/src/dev/miniflare.ts 60.38% <95.00%> (+5.28%) ⬆️
packages/wrangler/src/api/startDevWorker/index.ts 50.00% <50.00%> (ø)
... and 13 more

... and 4 files with indirect coverage changes

@mrbbot mrbbot merged commit 29df8e1 into main Nov 30, 2023
17 checks passed
@mrbbot mrbbot deleted the revert-4531-revert-4497-startDevWorker-release branch November 30, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants