-
Notifications
You must be signed in to change notification settings - Fork 178
wrangler.toml Secrets #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @Nasherx - two things.
Hope this helps 😄 |
Yep, @EverlastingBugstopper is totally right! While there isn't a variable set up in the action to handle this, you should be able to use GitHub Action's built-in env var support: - name: Publish
uses: cloudflare/wrangler-action@1.1.0
env:
CF_ACCOUNT_ID: {{ secrets.cf_account_id }}
CF_ZONE_ID: {{ secrets.cf_zone_id }} The above is kinda pseudo-code, I haven't tested it, so if that works, let me know! Would be useful to document in the README 👍 |
Adding the env variables still fails but i think its just my lack of understanding, I'm only just getting back into development. If its fine to have account ID and zone ID public then i'm happy 😊 |
along with zone id ref cloudflare/wrangler-action#17
In case you're like me and finding this later, the code snippet is almost right; it's just missing a Here's the step I'm using (also with
|
_ while CF account ID is not sensitive information, to make it easier for users to deploy this project; you might want to consider using an env variable instead (cloudflare/wrangler-action#17 (comment)) - added a gh secret to specify the project name - added support for specifying deployment env - added instructions on how to deploy to the README
Cannot see a way of keeping the Account ID and Zone ID a secret within github. The Github Actions secrets don't work within the file. I'm sure it's possible but I'm missing it in the documentation somewhere
This doesn't work
Whereas this works without an issue
The text was updated successfully, but these errors were encountered: