Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(widget-add-modal): add preview image of widgets #519

Merged
merged 3 commits into from Dec 22, 2022
Merged

fix(widget-add-modal): add preview image of widgets #519

merged 3 commits into from Dec 22, 2022

Conversation

yuda110
Copy link
Member

@yuda110 yuda110 commented Dec 22, 2022 •
edited

To Reviewers

  • Skip (style, chore ONLY)
  • Not that difficult

Type of Change

  • New feature
  • Bug fixes
  • Feature improvement
  • Refactor
  • Others (performance improvement, refactoring, CI/CD, etc.)

Checklist

  • Error / Warning / Lint / Type

Description

스크린샷 2022-12-22 오전 11 36 32

Things to Talk About

I use !important in css to fix style bug

song2kim
song2kim approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@song2kim song2kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~:)

@yuda110
Copy link
Member Author

yuda110 commented Dec 22, 2022

@h22y25n would give me an error image later :)

@yuda110 yuda110 merged commit da0b513 into cloudforet-io:master Dec 22, 2022
@yuda110 yuda110 deleted the feature/widget-image branch December 22, 2022 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@song2kim song2kim song2kim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yuda110 @song2kim