$LATTICE_COORDINATOR_IP can be overridden for non-aws bootstrap #7

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

drnic commented Dec 30, 2014

No description provided.

@davidwadden davidwadden self-assigned this Dec 31, 2014

Contributor

davidwadden commented Dec 31, 2014

the syntax looks right, but i'm trying to test it end to end for what you're looking to do. i would assume you'd want to do like LATTICE_COORDINATOR_IP=x.x.x.x vagrant up and basically have that in scope when the bootstrap script runs whether to persist it in our lattice-environment file, or default it to localhost as a default.

did you have another way of getting this environment variable in scope for the bootstrap script? this is invoked from one of the upstart scripts, and the above invocation doesn't seem to propagate it down to ever get anything besides the default localhost value. i'm looking into how to get that variable into scope when it's passed along with vagrant up at the moment .. if i can make that work, we'll pull this in..

dajulia3 commented Jan 5, 2015

@davidwadden is correct that we would need to do a little more work to get this working.
In the Vagrantfile, you'd have to pass the LATTICE_COORDINATOR_IP into the install_from_tar script as an argument and propogate that value down to the upstart bootstrap script. With that change, the code you have provided should work. We'd be happy to look at an updated PR for this behavior.

drnic commented Jan 5, 2015

I wasn't using the install_from_tar in the ansible playbook repo. I'll look at it for the PR

On Mon, Jan 5, 2015 at 8:26 AM, David Julia notifications@github.com
wrote:

@davidwadden is correct that we would need to do a little more work to get this working.

In the Vagrantfile, you'd have to pass the LATTICE_COORDINATOR_IP into the install_from_tar script as an argument and propogate that value down to the upstart bootstrap script. With that change, the code you have provided should work. We'd be happy to look at an updated PR for this behavior.

Reply to this email directly or view it on GitHub:
pivotal-cf-experimental#7 (comment)

davidwadden added a commit that referenced this pull request Feb 20, 2015

Merge pull request #7 from drnic/open-example
show the url for how to view example app in browser
Contributor

davidwadden commented Mar 13, 2015

We're closing this PR for now, as the files changed in the commit have been moved or no longer exist in our repository. If you wish to have this feature implemented, I encourage you to open an issue so we can figure out how to best implement your request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment