Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Deal with recent RVM change and rake 0.9.0 induced problems #67

Closed
wants to merge 2 commits into from

3 participants

@marklucovsky

This pull request contains 3 semi-related changes

#1 - declare the automating single command install is the only install option. It works well and is far less error prone than the manual process. Note, the auto start of the system is disabled with this change. While the start is a fine thing to do, unfortunately the shell the user is left running in is not capable of running bin/vcap stop so instead of auto starting, we ask users to exit and restart their shell and from there bin/vcap runs fine.

#2 - RVM recently changed to directly write into .bash_profile the startup sequence. The original change did this unconditionally and the net effect is that .bashrc isn't executed IFF RVM install is the one that created this file. The fix is to anticipate that RVM is going to do this write, and the pre-populate the .bash_profile file with proper loading of .bashrc.

#3 - The recent rake release 0.9.0 broke rails apps in a bad way. The cloud controller is a rails3 app and is impacted by this. With 0.9.0 rake gem installed the system does not boot. The fix in this pull request is twofold. First, we disable to global loading of the rake 0.9.0 gem by RVM and instead install the version specific 0.8.7 rake gem. Second, in vcap_setup where it loads some default system gems, we call out rake 0.8.7 explicitly in the gem install command.

Mark Lucovsky added some commits
Mark Lucovsky fix install issues caused by recent RVM change and free rake to 0.8.7…
… since 0.9.0 is broken for rails apps (like cloud controller)
9afa311
Mark Lucovsky re-add the edit of .bashrc, but fix the -z vs -n bug, and set rvm hom…
…e correctly
a12d6d0
@technomage

If you delete the manual install instructions, you need to provide steps for using a forked repository, since the automated one installs the official repo. The manual steps are also useful in allowing a snapshot prior to installing the source in case you want to return to that point to load a different repo.

@marklucovsky

I agree totally. The manual steps are very easy to do by hand by simply calling through setup/install manually rather then feeding it directly into bash. the other observation is that you can set the VCAP_REPO environment variable to auto-install from a separate repo:

VCAP_REPO=${VCAP_REPO:-https://github.com/cloudfoundry/vcap.git}

@technomage

The instructions for the automated install should include the presence of that option.

@pbozeman

pulled

@pbozeman pbozeman closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 23, 2011
  1. fix install issues caused by recent RVM change and free rake to 0.8.7…

    Mark Lucovsky authored
    … since 0.9.0 is broken for rails apps (like cloud controller)
  2. re-add the edit of .bashrc, but fix the -z vs -n bug, and set rvm hom…

    Mark Lucovsky authored
    …e correctly
This page is out of date. Refresh to see the latest.
Showing with 45 additions and 166 deletions.
  1. +9 −155 README.md
  2. +30 −10 setup/install
  3. +6 −1 setup/vcap_setup
View
164 README.md
@@ -48,7 +48,7 @@ a bringing up a VCAP instance. The other is an automated process contributed
by the community. In both cases, you need to start with a stock Ubuntu
server VM.
-### step -1:
+### Step 1: create a pristine VM with ssh
* setup a VM with a pristine Ubuntu 10.04.2 server 64bit image,
[download here](http://www.ubuntu.com/download/ubuntu/download)
@@ -60,9 +60,7 @@ To install ssh:
sudo apt-get install openssh-server
-### Automated Setup (experimental):
-
-#### Step 0:
+#### Step 2: run the automated setup process
Run the install script. It'll ask for your sudo password at the
beginning and towards the end. The entire process takes ~1 hour, so just
keep a loose eye on it.
@@ -70,161 +68,17 @@ keep a loose eye on it.
sudo apt-get install curl
bash < <(curl -s -k -B https://github.com/cloudfoundry/vcap/raw/master/setup/install)
-NOTE: if you have issues with 'vmc target api.vcap.me' after using the
-automated installer, exit out of the shell you did the install in, open
-a new shell, and perform the following operations:
-
- cd ~/cloudfoundry/vcap
- bin/vcap stop
- bin/vcap start
-
-Jump to step 9 in the manual process to optionally setup an ssh tunnel
-and test your installation.
-
-### Manual Setup:
-
-#### step 0: install system and rvm dependencies
-
- sudo apt-get install autoconf curl git-core ruby bison build-essential zlib1g-dev libssl-dev libreadline5-dev
-
-#### step 1: install rvm
-
-For detailed [rvm](https://rvm.beginrescueend.com/) install instructions see: [https://rvm.beginrescueend.com/rvm/install/](https://rvm.beginrescueend.com/rvm/install/) or follow the quick steps below.
-
-First install rvm using their script. Note: the `-k`
-switch is only needed if the certificate validation fails:
-
- bash < <(curl -s -k -B https://rvm.beginrescueend.com/install/rvm)
-
-Then follow the instructions given by the RVM
-installer (a copy is included below for your convenience).
-
- # you must complete the install by loading RVM in new shells.
- #
- #
- # 1) Place the folowing line at the end of your shell's loading files
- # (.bashrc or .bash_profile for bash and .zshrc for zsh),
- # after all PATH/variable settings:
- #
- # # This loads RVM into a shell session.
- # [[ -s \"$rvm_path/scripts/rvm\" ]] && source \"$rvm_path/scripts/rvm\"
- #
- # You only need to add this line the first time you install rvm.
- #
- # 2) Ensure that there is no 'return' from inside the ~/.bashrc file,
- # otherwise rvm may be prevented from working properly.
- #
- # This means that if you see something like:
- #
- # '[ -z \"\$PS1\" ] && return'
- #
- # then you change this line to:
- #
- # if [[ -n \"\$PS1\" ]] ; then
- #
- # # ... original content that was below the '&& return' line ...
- #
- # fi # <= be sure to close the if at the end of the .bashrc.
- #
- # # this is a good place to source rvm
- # [[ -s \"$rvm_path/scripts/rvm\" ]] && source \"$rvm_path/scripts/rvm\"
- #
- # <EOF> - this marks the end of the .bashrc
- #
- # Be absolutely *sure* to REMOVE the '&& return'.
- #
- # If you wish to DRY up your config you can 'source ~/.bashrc' at the
- # bottom of your .bash_profile.
- #
- # Placing all non-interactive (non login) items in the .bashrc,
- # including the 'source' line above and any environment settings.
- #
- # 3) CLOSE THIS SHELL and open a new one in order to use rvm.
-
-
-#### step 2: use rvm to install ruby 1.9.2 and make it default
-
- rvm install 1.9.2-p180
- rvm --default 1.9.2-p180
-
-#### step 3: use rvm to install ruby 1.8.7
-
- rvm install 1.8.7
-
-#### step 4: clone the vcap and vmc repos:
-
-Optionally create new ssh keys and add them to your github account:
-
- ssh-keygen -t rsa -C me@example.com
-
-Now create a directory for cloudfoundry and use git to clone the project into it:
-
- mkdir ~/cloudfoundry; cd ~/cloudfoundry
- git clone https://github.com/cloudfoundry/vcap.git
- cd ~/cloudfoundry/vcap
-
-The first time that you enter the vcap directory you may see an RVM warning
-noting a new or modified .rvmrc file. Follow the instructions to review
-the file and when asked to trust enter `yes` at the prompt.
-
-There should be a `.rvmrc` file in the `~/cloudfoundry/vcap` directory.
-Make sure that file is present and that it contains `rvm use 1.9.2`.
-
-This release uses a handful of submodules. After cloning the vcap repo, you must run:
-
- git submodule update --init
-
-This will check out additional resources which are required for the
-project to run.
-
-*NOTE:* Any time that you update the project with `git pull` you
-must `git submodule update` afterwards or you will not have a complete
-copy of the latest code.
-
-Now install the vmc gem (command line tools for interacting with the platform):
-
- gem install vmc --no-rdoc --no-ri
-
-#### step 5: run vcap_setup to prep cloudfoundry for launch
-
-Points to keep in mind:
-
-1). Answer Y to all questions
-
-2). Remember your mysql password, you will need it in a minute
-
- cd ~/cloudfoundry/vcap
- sudo setup/vcap_setup
-
-This step may take a long time as your selections are downloaded and built as needed.
-
-After `vcap_setup` completes, edit your `mysql_node.yml` config file:
-
- cd ~/cloudfoundry/vcap/services/mysql/config
- vi mysql_node.yml # or use your editor of choice
-
-Change the `pass` in the `mysql` section to the mysql root password
-you created during install and save.
-
-#### step 6: restart nginx with a custom config
-
- cd ~/cloudfoundry/vcap
- sudo cp setup/simple.nginx.conf /etc/nginx/nginx.conf
- sudo /etc/init.d/nginx restart
-
-#### step 7: install bundler gem and run bundler:install
-
- cd ~/cloudfoundry/vcap
- gem install bundler --no-rdoc --no-ri
- rake bundler:install
+NOTE: The automated setup does not auto-start the system. Once you are
+done with the setup, exit your current shell, restart a new shell and continue
+the following steps
-#### step 8: start the system
+#### Step 3: start the system
cd ~/cloudfoundry/vcap
bin/vcap start
bin/vcap tail # see aggregate logs
-#### step 9: *Optional, mac users only*, create a local ssh tunnel
+#### Step 4: *Optional, mac users only*, create a local ssh tunnel
From your VM, run `ifconfig` and note your eth0 IP address, which will look something like: `192.168.252.130`
@@ -246,7 +100,7 @@ will map to localhost which will map to your running Cloud Foundry instance.
Trying your setup
-----------------
-### step 10: validate that you can connect and tests pass
+### Step 5: validate that you can connect and tests pass
#### From the console of your vm, or from your mac (thanks to local tunnel)
vmc target api.vcap.me
@@ -291,7 +145,7 @@ Validation Tests (BVT) to ensure that major functionality is working.
cd ../health_manager
rake spec
-### step 11: you are done, make sure you can run a simple hello world app.
+### Step 6: you are done, make sure you can run a simple hello world app.
Create an empty directory for your test app (lets call it env), and enter it.
View
40 setup/install
@@ -41,13 +41,24 @@ elif [[ $PLATFORM == 'MacOSX' ]]; then
MYSQL_PASS="$(md5 -qs "$(date)")"
fi
+echo "Patch around .bash_profile issue with RMV"
+if [ -f ~/.bashrc ]; then
+ if [ ! -f ~/.bash_profile ]; then
+ # rvm install is going to write into .bash_profile in this
+ # case and short circuit loading of .bashrc so we need to
+ # create a proper .bash_profile if its missing
+ echo "# This file is sourced by bash for login shells. The following line" >> ~/.bash_profile
+ echo "# runs your .bashrc and is recommended by the bash info pages." >> ~/.bash_profile
+ echo "[[ -f ~/.bashrc ]] && . ~/.bashrc" >> ~/.bash_profile
+ fi
+fi
+
echo "Installing rvm"
curl -s -k -B https://rvm.beginrescueend.com/install/rvm > /tmp/install_rvm
bash /tmp/install_rvm
rm /tmp/install_rvm
echo "Fixing init scripts to work with rvm"
-
init_file=""
if [ -f ~/.bashrc ]; then
init_file="$HOME/.bashrc"
@@ -56,27 +67,36 @@ elif [ -f ~/.bash_profile ]; then
elif [ -f ~/.zshrc ]; then
init_file="$HOME/.zshrc"
fi
-
if [ -f "$init_file" ]; then
- echo "Fixing init scripts to work with rvm"
if grep '^ *\[ -z "$PS1" \] && return *$' $init_file; then
- sed -i.bkup -e 's/^ *\[ -z "$PS1" \] && return *$/if [ -z "$PS1" ]; then/' $init_file
+ sed -i.bkup -e 's/^ *\[ -z "$PS1" \] && return *$/if [ -n "$PS1" ]; then/' $init_file
echo "fi" >> $init_file
fi
- echo '[[ -s "$rvm_path/scripts/rvm" ]] && source "$rvm_path/scripts/rvm"' >> $init_file
+ echo '[[ -s "$HOME/.rvm/scripts/rvm" ]] && source "$HOME/.rvm/scripts/rvm"' >> $init_file
fi
-echo "Fixing init scripts to work with rvm"
-
+echo "Activate rvm"
rvm_path="$HOME/.rvm"
[[ -s "$rvm_path/scripts/rvm" ]] && source "$rvm_path/scripts/rvm"
+type rvm | head -1
+
+# remove rake from default and global gems and instead install manually
+rm ~/.rvm/gemsets/default.gems
+rm ~/.rvm/gemsets/global.gems
echo "Installing various rubies"
rvm install 1.9.2-p180
rvm --default 1.9.2-p180
rvm install 1.8.7
+# install only rake 0.8.7
+rvm use 1.8.7
+gem install rake --version '0.8.7' --no-rdoc --no-ri
+
+rvm use 1.9.2
+gem install rake --version '0.8.7' --no-rdoc --no-ri
+
echo "Getting vcap"
[ -d ~/cloudfoundry ] || mkdir ~/cloudfoundry
cd ~/cloudfoundry
@@ -104,8 +124,8 @@ cd ~/cloudfoundry/vcap
gem install bundler --no-rdoc --no-ri
rake bundler:install
-echo 'Starting it up!'
-cd ~/cloudfoundry/vcap/bin
-./vcap start
+# don't start up vcap in this shell
+# its best to exit the shell and then
+# come back in so that the .rvmrc in cloudfoundry/vcap activates correctly
echo 'Success!'
View
7 setup/vcap_setup
@@ -298,7 +298,12 @@ if [[ $DEA == true || $ALL == true ]]; then
echo "Installing some default system gems"
echo "gem: --no-rdoc --no-ri" > ~/.gemrc
- gem install rack rake thin sinatra eventmachine
+
+ # original code did this in one shot, BUT with the rake issues with 0.9.0 and rails 3
+ # we hard version the rake gem to 0.8.7 since that is the only one that really works
+ gem install rack
+ gem install rake --version '0.8.7'
+ gem install thin sinatra eventmachine
if [ ! -d '/var/vcap.local' ]; then
echo "Creating directory /var/vcap.local"
Something went wrong with that request. Please try again.