New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Clojure support #96

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@mikeivanov

mikeivanov commented Aug 11, 2011

CloudFoundry does not have native Clojure support. Here I fixed it. It's just like Heroku's - http://blog.heroku.com/archives/2011/7/5/clojure_on_heroku/Dear Cloud Foundry contributor,

If you are reading this message, it means you submitted a pull request in the Cloud Foundry GitHub repository.

First of all, thanks! We really appreciate your participation.

Recently we made some changes in how we are verifying and reviewing open source contributions like yours. In addition, we changed the way we can expose our internal development in real-time. The changes are exciting, as they allow all our staff to collaborate seamlessly with you, which increases our mutual velocity and gives the community a bigger stake in our direction.

The Cloud Foundry team uses Gerrit, a code review tool that originated in the Android Open Source Project. We also use GitHub as an official mirror, though all pull requests are accepted via Gerrit.

Follow these steps to make a contribution to any of our open source repositories:

  1. Complete our CLA Agreement for
    individuals or
    corporations.

  2. Sign up for an account on our public Gerrit server at
    http://reviews.cloudfoundry.org/.

  3. Create and upload your public SSH key in your Gerrit account profile.

  4. Set your name and email:

            git config --global user.name "Firstname Lastname"
            git config --global user.email "your_email@youremail.com"
    
  5. Install our gerrit-cli gem:

            gem install gerrit-cli
    
  6. Clone the Cloud Foundry repo:
    Note: to clone the BOSH repo, or the Documentation repo, replace
    vcap with bosh or oss-docs

            gerrit clone ssh://reviews.cloudfoundry.org:29418/vcap
            cd vcap
    
  7. Make your changes, commit, and push to gerrit:

            git commit
            gerrit push
    

Once your commits are approved by our Continuous Integration Bot (CI Bot) as well as our engineering staff, return to the Gerrit interface and MERGE your changes. The merge will be replicated to GitHub automatically at https://github.com/cloudfoundry. If you get feedback on your submission, we recommend squashing your commit with the original change-id. See the squashing section here for more details: https://help.github.com/rebase.

@mikeivanov

This comment has been minimized.

mikeivanov commented Aug 11, 2011

@mikeivanov mikeivanov closed this Aug 11, 2011

@mikeivanov mikeivanov reopened this Aug 11, 2011

@pbozeman

This comment has been minimized.

Contributor

pbozeman commented Aug 25, 2011

Could you add a simple closure app to the vcap-tests suite? The python and php ones are good models to follow as they only run if the framework is enabled in the backend.

Thanks

@mikeivanov

This comment has been minimized.

mikeivanov commented Aug 25, 2011

@myarkoni

This comment has been minimized.

myarkoni commented Nov 11, 2011

Mike, did you get my message about the CLA signing? We need it in order to process your PR.

@mikeivanov

This comment has been minimized.

mikeivanov commented Nov 11, 2011

Just have sent it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment