Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable overwritten #18

Open
ghost opened this issue Feb 13, 2016 · 2 comments
Open

Environment variable overwritten #18

ghost opened this issue Feb 13, 2016 · 2 comments

Comments

@ghost
Copy link

ghost commented Feb 13, 2016

cf-meteor-buildpack/bin/release

extract_root_url()

Custom domains are ignored. If I set an user variable with ROOT_URL, it is ignored and only the VCAP application is taken. While this is nice with the standard settings it causes problems if you want to overwrite this with a custom domain on purpose. (using bluemix, not sure if this is a common problem)

It would be nice to have a check if there is an existing environment variable and only set a new one if there is not.

@djules75
Copy link

I have the same problem. I'm using a custom domain and the ROOT_URL environment variable that I set through 'cf env' is overridden by the standard settings from the buildpack. Any solution for this?

@djules75
Copy link

Just implemented a work around using a BLUEMIX_ROOT_URL env variable, then, in my init script on server side:

if (process.env.BLUEMIX_ROOT_URL) {
  __meteor_runtime_config__.ROOT_URL = process.env.BLUEMIX_ROOT_URL;
  Meteor.absoluteUrl.defaultOptions.rootUrl = process.env.BLUEMIX_ROOT_URL;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant