Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Incompatiblity with CF diego release #11
Recently we have tested our "HelloWorld" nodejs apps on the diego part of CF. As can be followed from the release notes https://github.com/cloudfoundry-incubator/diego-design-notes, several env variables inside of containers were deprecated.
The call of 'cfenv.getAppEnv' causes the following error: 'Error: cfenv: expecting VCAP_APPLICATION to contain uris when not runninng locally'
Could you please test the code on diego or let me know if I can somehow help here?
Thanks in advance.
I don't have a clue as to how I would test on diego. I'm not set up to run a CF install. If there's a Docker image that just runs, zero setup time, that I can test with - or something similar - let me know. Or is anyone running some kind of a sandbox live?
With regard to the changes, I guess this is the relevant info?
Looks like we can make a fix here: lib-src/cfenv.coffee
Something like from:
uris = appEnv.app?.uris
uris = appEnv.app?.uris || 
Might work. Wanna give it a try?
The equivalent line in the js file, if you don't want to futz with a build, and just whack it to try it, is here: lib/cfenv.js
That change would be something like from:
uris = (ref = appEnv.app) != null ? ref.uris : void 0;
uris = (ref = appEnv.app) != null ? ref.uris : ;
@vvraskin - I have a branch for you to try. In your
You can also use that from the command-line, to install locally, without referencing your
Let me know if it works, I'll push it up to npm as a new version.