Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cf local with the app's manifest.yml #3

Open
ngscchung opened this issue Apr 21, 2017 · 2 comments

Comments

@ngscchung
Copy link

@ngscchung ngscchung commented Apr 21, 2017

I found that cf local run or stage will not recognize my manifest.yml. I have to re-input those info like app names or host through command line or create a separate local.yml ... is it possible to make cf local recognize the app's original manifest.yml?

@sclevine

This comment has been minimized.

Copy link
Member

@sclevine sclevine commented Apr 26, 2017

Ignoring manifest.yml is an intentional design decision that I don't currently have plans to change.

Reasons include:

  • Local app configuration and remote app configuration are often different. The service credentials, environment secrets, and app domain are generally going to be different for locally-running apps.
  • The manifest.yml format is missing many configuration options that CF Local needs or will need, such as full service binding credentials, staging/running environment variable groups, and droplet file paths.
  • It would be confusing to modify manifest.yml on cf local pull, and doing so could result in adding secrets to manifest.yml that should not be checked into VCS.

I might consider adding an option to local.yml to use the environment variables from an app specified in manifest.yml. Is this a compelling option for your use case?

@ngscchung

This comment has been minimized.

Copy link
Author

@ngscchung ngscchung commented Apr 27, 2017

Our use case is to setup our deployment pipeline to trigger cf local and construct an unittest environment that is (almost) identical to the actual CF runtime environment and run the unittest before cf push.

Understand your design idea and your suggested enhancement will help. Originally I'm just thinking if cf local would follow the original manifest.yml by default, and override/supplement any additional options specified in local.yml that are specific for cf local usage, but it's okay if you want to prevent any potential confusions.

@sclevine sclevine added this to Icebox in CF Local Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CF Local
  
Icebox
2 participants
You can’t perform that action at this time.