Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upChange common_name for docker cert #229
Conversation
This comment has been minimized.
This comment has been minimized.
cf-gitbot
commented
Nov 17, 2017
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/152982409 The labels on this github issue will be updated when the story is started. |
This comment has been minimized.
This comment has been minimized.
cfdreddbot
commented
Nov 17, 2017
|
Hey alex-slynko! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
cf-gitbot
added
the
unscheduled
label
Nov 17, 2017
jhvhs
merged commit 27faf9f
into
master
Nov 21, 2017
jhvhs
deleted the
docker_tls_common_name
branch
Nov 21, 2017
cf-gitbot
added
in progress
delivered
accepted
and removed
unscheduled
in progress
delivered
labels
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
alex-slynko commentedNov 17, 2017
I chose a random name that is not a real name for the worker VM.
But it is definitely not
kubernetes_master_host.