Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change common_name for docker cert #229

Merged
merged 2 commits into from Nov 21, 2017
Merged

Change common_name for docker cert #229

merged 2 commits into from Nov 21, 2017

Conversation

@alex-slynko
Copy link
Member

@alex-slynko alex-slynko commented Nov 17, 2017

I chose a random name that is not a real name for the worker VM.
But it is definitely not kubernetes_master_host.

I chose a random name that is not a real name for the worker VM.
But it is definitely not `kubernetes_master_host`.
@cf-gitbot
Copy link

@cf-gitbot cf-gitbot commented Nov 17, 2017

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/152982409

The labels on this github issue will be updated when the story is started.

@cfdreddbot
Copy link

@cfdreddbot cfdreddbot commented Nov 17, 2017

Hey alex-slynko!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@jhvhs jhvhs merged commit 27faf9f into master Nov 21, 2017
@jhvhs jhvhs deleted the docker_tls_common_name branch Nov 21, 2017
lubronzhan pushed a commit to pivotal-cf/pks-kubo-deployment that referenced this pull request Apr 18, 2019
…tor#229)

[#158904932]

Signed-off-by: Angela Chin <achin@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.