New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added namespaces to the cluster, creds and context in set_kubeconfig #235

Merged
merged 2 commits into from Nov 27, 2017

Conversation

Projects
None yet
4 participants
@tvs
Member

tvs commented Nov 22, 2017

Without a namespace based on the bosh environment, clusters given the
same name will collide with one another and users must re-run
set_kubeconfig every time they wish to switch between a cluster. With
the namespaces, that should reduce the likelihood of a collision and
allow users to switch using kubectl config use-context <context-name>.

Issue #223.

[#152752429]

Added namespaces to the cluster, creds and context in set_kubeconfig
Without a namespace based on the bosh environment, clusters given the
same name will collide with one another and users must re-run
set_kubeconfig every time they wish to switch between a cluster. With
the namespaces, that should reduce the likelihood of a collision and
allow users to switch using `kubectl config use-context <context-name>`.

[#152752429]
@cfdreddbot

This comment has been minimized.

cfdreddbot commented Nov 22, 2017

Hey tvs!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot

This comment has been minimized.

cf-gitbot commented Nov 22, 2017

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/153106509

The labels on this github issue will be updated when the story is started.

@mordebites

looks good to me

@mordebites mordebites merged commit 56e84f7 into master Nov 27, 2017

@cf-gitbot cf-gitbot removed the unscheduled label Nov 27, 2017

drnic added a commit to drnic/kubo-deployment that referenced this pull request Nov 27, 2017

@cf-gitbot cf-gitbot added the accepted label Nov 28, 2017

drnic added a commit to drnic/kubo-deployment that referenced this pull request Nov 29, 2017

drnic added a commit to drnic/kubo-deployment that referenced this pull request Nov 29, 2017

drnic added a commit to drnic/kubo-deployment that referenced this pull request Nov 30, 2017

@BenChapman BenChapman deleted the bug/namespaced_kubeconfig branch Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment