Added namespaces to the cluster, creds and context in set_kubeconfig #235
Conversation
Without a namespace based on the bosh environment, clusters given the same name will collide with one another and users must re-run set_kubeconfig every time they wish to switch between a cluster. With the namespaces, that should reduce the likelihood of a collision and allow users to switch using `kubectl config use-context <context-name>`. [#152752429]
|
Hey tvs! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/153106509 The labels on this github issue will be updated when the story is started. |
|
looks good to me |
drnic
added a commit
to drnic/kubo-deployment
that referenced
this pull request
Nov 27, 2017
drnic
added a commit
to drnic/kubo-deployment
that referenced
this pull request
Nov 29, 2017
drnic
added a commit
to drnic/kubo-deployment
that referenced
this pull request
Nov 29, 2017
drnic
added a commit
to drnic/kubo-deployment
that referenced
this pull request
Nov 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Without a namespace based on the bosh environment, clusters given the
same name will collide with one another and users must re-run
set_kubeconfig every time they wish to switch between a cluster. With
the namespaces, that should reduce the likelihood of a collision and
allow users to switch using
kubectl config use-context <context-name>.Issue #223.
[#152752429]