Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup docker container log options #266

Merged
merged 2 commits into from Feb 20, 2018

Conversation

Projects
None yet
4 participants
@rapenchukd
Copy link
Contributor

rapenchukd commented Feb 15, 2018

This should work according to:
https://github.com/cloudfoundry-incubator/docker-boshrelease/blob/master/jobs/docker/spec#L95
and https://docs.docker.com/engine/admin/logging/json-file/#usage

Essentially, we don't want to crash our servers because some long running container is spewing too much to the logs. We will cap size to 128m, and retain one old copy just for the sake of emergencies. I think this makes sense as a starter default.

Setup docker container log options
This should work according to:
https://github.com/cloudfoundry-incubator/docker-boshrelease/blob/master/jobs/docker/spec#L95
and https://docs.docker.com/engine/admin/logging/json-file/#usage

Essentially, we don't want to crash our servers because some long running container is spewing too much to the logs. We will cap size to 128m, and retain one old copy just for the sake of emergencies.  I think this makes sense as  a starter default.
@cfdreddbot

This comment has been minimized.

Copy link

cfdreddbot commented Feb 15, 2018

Hey rapenchukd!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot

This comment has been minimized.

Copy link

cf-gitbot commented Feb 15, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/155265676

The labels on this github issue will be updated when the story is started.

@christianang
Copy link
Member

christianang left a comment

This sounds okay to me. Thanks.

@christianang christianang merged commit 1e9e121 into cloudfoundry-incubator:master Feb 20, 2018

1 check passed

concourse-ci/status Concourse CI build success
Details

@cf-gitbot cf-gitbot added accepted and removed unscheduled labels Feb 20, 2018

svrc-pivotal added a commit to svrc-pivotal/azure-kubo-deployment that referenced this pull request Apr 1, 2018

Setup docker container log options (cloudfoundry-incubator#266)
This should work according to:
https://github.com/cloudfoundry-incubator/docker-boshrelease/blob/master/jobs/docker/spec#L95
and https://docs.docker.com/engine/admin/logging/json-file/#usage

Essentially, we don't want to crash our servers because some long running container is spewing too much to the logs. We will cap size to 128m, and retain one old copy just for the sake of emergencies.  I think this makes sense as  a starter default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.