Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cluster-signing property for the kube-controller-manager job #281

Merged
merged 2 commits into from Apr 24, 2018

Conversation

@bsnchan
Copy link
Contributor

@bsnchan bsnchan commented Mar 16, 2018

@cfdreddbot
Copy link

@cfdreddbot cfdreddbot commented Mar 16, 2018

Hey bsnchan!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

@cf-gitbot cf-gitbot commented Mar 16, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/156052853

The labels on this github issue will be updated when the story is started.

@glestaris
Copy link
Contributor

@glestaris glestaris commented Mar 21, 2018

hey @bsnchan, we decided to merge cloudfoundry-incubator/kubo-release#179 and #269 to enable the TLS bootstrapping feature.

Does this PR make sense if we merge the TLS bootstrapping PRs or is this a subset of the TLS bootstrapping PRs?

@bsnchan
Copy link
Contributor Author

@bsnchan bsnchan commented Mar 27, 2018

Yep - looks like that PR will do the job! Thanks @glestaris!

@cfdreddbot
Copy link

@cfdreddbot cfdreddbot commented Apr 24, 2018

Hey bsnchan!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

@cf-gitbot cf-gitbot commented Apr 24, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/157048586

The labels on this github issue will be updated when the story is started.

@cf-gitbot cf-gitbot added unscheduled and removed accepted labels Apr 24, 2018
@bsnchan
Copy link
Contributor Author

@bsnchan bsnchan commented Apr 24, 2018

@tvs
tvs approved these changes Apr 24, 2018
@cf-gitbot cf-gitbot added in progress and removed scheduled labels Apr 24, 2018
@tvs tvs merged commit 392d22f into cloudfoundry-incubator:master Apr 24, 2018
lubronzhan pushed a commit to pivotal-cf/pks-kubo-deployment that referenced this pull request Apr 18, 2019
It's failing vsphere-lb part of the pipeline, but vsphere-lb is failing everywhere so we're merging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants