Remove unused terraform variable from kubo-lbs.tf #283
Conversation
This variable is not used within the template. With this change, step 3 in "Step 2: Configure Load Balancers" in cfcf docs needs to be updated to no longer supply this variable to the terraform apply command (https://docs-cfcr.cfapps.io/installing/gcp/routing-gcp/#step-2-configure-load-balancers)
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/156250207 The labels on this github issue will be updated when the story is started. |
|
Hey ishustava! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
Thank you for catching this and making a PR @ishustava! |
lubronzhan
pushed a commit
to pivotal-cf/pks-kubo-deployment
that referenced
this pull request
Apr 18, 2019
…loudfoundry-incubator#283) * Made kube-apiserver's audit policy configurable through the manifest * Made audit-policy an optional parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This variable is not used within the template.
With this change, step 3 in "Step 2: Configure Load Balancers" in cfcf docs needs to be updated to no longer supply this variable to the terraform apply command (https://docs-cfcr.cfapps.io/installing/gcp/routing-gcp/#step-2-configure-load-balancers).