Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unused terraform variable from kubo-lbs.tf #283
Conversation
This comment has been minimized.
This comment has been minimized.
cf-gitbot
commented
Mar 24, 2018
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/156250207 The labels on this github issue will be updated when the story is started. |
This comment has been minimized.
This comment has been minimized.
cfdreddbot
commented
Mar 24, 2018
|
Hey ishustava! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
cf-gitbot
added
the
unscheduled
label
Mar 24, 2018
This comment has been minimized.
This comment has been minimized.
|
Thank you for catching this and making a PR @ishustava! |
youreddy
merged commit ff42044
into
cloudfoundry-incubator:master
May 1, 2018
cf-gitbot
added
delivered
accepted
and removed
unscheduled
delivered
labels
May 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ishustava commentedMar 24, 2018
This variable is not used within the template.
With this change, step 3 in "Step 2: Configure Load Balancers" in cfcf docs needs to be updated to no longer supply this variable to the terraform apply command (https://docs-cfcr.cfapps.io/installing/gcp/routing-gcp/#step-2-configure-load-balancers).