Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused terraform variable from kubo-lbs.tf #283

Merged
merged 2 commits into from May 1, 2018

Conversation

@ishustava
Copy link
Contributor

@ishustava ishustava commented Mar 24, 2018

This variable is not used within the template.

With this change, step 3 in "Step 2: Configure Load Balancers" in cfcf docs needs to be updated to no longer supply this variable to the terraform apply command (https://docs-cfcr.cfapps.io/installing/gcp/routing-gcp/#step-2-configure-load-balancers).

This variable is not used within the template.

With this change, step 3 in "Step 2: Configure Load Balancers" in cfcf docs needs to be updated to no longer supply this variable to the terraform apply command (https://docs-cfcr.cfapps.io/installing/gcp/routing-gcp/#step-2-configure-load-balancers)
@cf-gitbot
Copy link

@cf-gitbot cf-gitbot commented Mar 24, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/156250207

The labels on this github issue will be updated when the story is started.

@cfdreddbot
Copy link

@cfdreddbot cfdreddbot commented Mar 24, 2018

Hey ishustava!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

Urvashi Reddy
@youreddy
Copy link
Contributor

@youreddy youreddy commented May 1, 2018

Thank you for catching this and making a PR @ishustava!

@youreddy youreddy merged commit ff42044 into cloudfoundry-incubator:master May 1, 2018
lubronzhan pushed a commit to pivotal-cf/pks-kubo-deployment that referenced this pull request Apr 18, 2019
…loudfoundry-incubator#283)

* Made kube-apiserver's audit policy configurable through the manifest

* Made audit-policy an optional parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants