Escape backslashes for vsphere users #121
Merged
Conversation
Kubernetes-controller-manager requires usernames to be escaped, whereas the kubelet prestart script that uses govc does not
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/151965138 The labels on this github issue will be updated when the story is started. |
|
Hey svrc-pivotal! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
Thanks @svrc-pivotal we will talk about this PR with the PMs |
Closed
jfmyers9
merged commit 123424f
into
cloudfoundry-incubator:master
1 check passed
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Kubernetes-controller-manager requires usernames with backslashes (NTLM-style logins) to be escaped, whereas the kubelet prestart script that uses govc does not.