New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape backslashes for vsphere users #121

Merged
merged 6 commits into from Dec 12, 2017

Conversation

Projects
None yet
8 participants
@svrc-pivotal
Contributor

svrc-pivotal commented Oct 13, 2017

Kubernetes-controller-manager requires usernames with backslashes (NTLM-style logins) to be escaped, whereas the kubelet prestart script that uses govc does not.

Escape backslashes for vsphere users
Kubernetes-controller-manager requires usernames to be escaped, whereas the kubelet prestart script that uses govc does not
@cf-gitbot

This comment has been minimized.

cf-gitbot commented Oct 13, 2017

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/151965138

The labels on this github issue will be updated when the story is started.

@cfdreddbot

This comment has been minimized.

cfdreddbot commented Oct 13, 2017

Hey svrc-pivotal!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@Manifaust

This comment has been minimized.

Member

Manifaust commented Oct 16, 2017

Thanks @svrc-pivotal we will talk about this PR with the PMs

@svrc-pivotal svrc-pivotal referenced this pull request Nov 4, 2017

Closed

Password escapes #125

jhvhs and others added some commits Nov 6, 2017

@cf-gitbot cf-gitbot added scheduled and removed unscheduled labels Nov 30, 2017

@cf-gitbot cf-gitbot added in progress and removed scheduled labels Dec 11, 2017

akshaymankar added some commits Dec 11, 2017

@jfmyers9 jfmyers9 merged commit 123424f into cloudfoundry-incubator:master Dec 12, 2017

1 check passed

concourse-ci/status Concourse CI build success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment