Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEscape backslashes for vsphere users #121
Conversation
This comment has been minimized.
This comment has been minimized.
cf-gitbot
commented
Oct 13, 2017
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/151965138 The labels on this github issue will be updated when the story is started. |
cf-gitbot
added
the
unscheduled
label
Oct 13, 2017
This comment has been minimized.
This comment has been minimized.
cfdreddbot
commented
Oct 13, 2017
|
Hey svrc-pivotal! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
This comment has been minimized.
This comment has been minimized.
|
Thanks @svrc-pivotal we will talk about this PR with the PMs |
jhvhs
and others
added some commits
Nov 6, 2017
cf-gitbot
added
scheduled
and removed
unscheduled
labels
Nov 30, 2017
cf-gitbot
added
in progress
and removed
scheduled
labels
Dec 11, 2017
akshaymankar
added some commits
Dec 11, 2017
cf-gitbot
added
scheduled
in progress
and removed
in progress
scheduled
labels
Dec 12, 2017
jfmyers9
merged commit 123424f
into
cloudfoundry-incubator:master
Dec 12, 2017
1 check passed
concourse-ci/status
Concourse CI build success
Details
cf-gitbot
added
delivered
accepted
and removed
in progress
delivered
labels
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
svrc-pivotal commentedOct 13, 2017
Kubernetes-controller-manager requires usernames with backslashes (NTLM-style logins) to be escaped, whereas the kubelet prestart script that uses govc does not.