Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support 'nats' link that is already implemented in template #134

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
4 participants
@drnic
Copy link
Contributor

drnic commented Nov 26, 2017

The dual use of p('nats.xyz') and link('nats') is already in the template; but the nats link is not supported in the spec. This is fixed in this PR.

Just like https://github.com/cloudfoundry-incubator/routing-release/blob/develop/jobs/route_registrar/spec this requires that we do not provide default values for nats.port etc in the spec file.

This will not break kubo-deployment which is currently explicitly setting all properties in its cf-routing.yml.

One this PR is merged, we can switch to using nats link in cf-routing.yml.

@cfdreddbot

This comment has been minimized.

Copy link

cfdreddbot commented Nov 26, 2017

Hey drnic!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot

This comment has been minimized.

Copy link

cf-gitbot commented Nov 26, 2017

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/153153910

The labels on this github issue will be updated when the story is started.

@drnic

This comment has been minimized.

Copy link
Contributor Author

drnic commented Nov 26, 2017

Could you please make the CI jobs public so can see errors?
screen shot 2017-11-27 at 9 22 25 am

Or can @drnic be added to the authorized ppl please?

Though, I don't think this PR would break run-k8s-integration-tests-gcp-lb specifically.

@drnic drnic force-pushed the drnic:nats-link branch from e504fbe to e1dcd26 Nov 28, 2017

@mordebites mordebites merged commit 156f351 into cloudfoundry-incubator:master Nov 28, 2017

1 check was pending

concourse-ci/status Concourse CI build pending
Details

@cf-gitbot cf-gitbot added accepted and removed unscheduled labels Nov 28, 2017

@drnic drnic deleted the drnic:nats-link branch Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.