Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Parameters for logging level change #151

Merged

Conversation

@shinji62
Copy link
Contributor

@shinji62 shinji62 commented Jan 4, 2018

Activating debugging logs or changing verbosity of the logs could be helpful especially when dealing with k8s.

This PR made this possible and for each k8s component.

At the same time I fix some minor issue like uneeded " and one missing /

@glestaris

@cfdreddbot
Copy link

@cfdreddbot cfdreddbot commented Jan 4, 2018

Hey shinji62!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

@cf-gitbot cf-gitbot commented Jan 4, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/154041750

The labels on this github issue will be updated when the story is started.

@tvs
tvs approved these changes Jan 4, 2018
Copy link
Member

@tvs tvs left a comment

Looks good to me. Thanks @shinji62.

@tvs tvs merged commit cebc32d into cloudfoundry-incubator:master Jan 4, 2018
1 check passed
1 check passed
concourse-ci/status Concourse CI build success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.