Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to kubelet option to configure allow-privileged #153

Conversation

@shinji62
Copy link
Contributor

@shinji62 shinji62 commented Jan 4, 2018

Not sure is good to allow to true by default even if the apiserver is false.

This PR will put to false by default and add the options to setup to true.

I will send a PR to kubo-deployment too.

@cfdreddbot
Copy link

@cfdreddbot cfdreddbot commented Jan 4, 2018

Hey shinji62!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

@cf-gitbot cf-gitbot commented Jan 4, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/154049081

The labels on this github issue will be updated when the story is started.

@shinji62
Copy link
Contributor Author

@shinji62 shinji62 commented Jan 4, 2018

@glestaris @tvs thanks

@glestaris
Copy link

@glestaris glestaris commented Jan 4, 2018

@shinji62
Copy link
Contributor Author

@shinji62 shinji62 commented Jan 4, 2018

@akshaymankar
Copy link
Contributor

@akshaymankar akshaymankar commented Jan 10, 2018

@shinji62 As the story mentioned by @glestaris is delivered and accepted, I guess this PR is not needed to be merged. Thanks anyways for your contribution :)

I guess same applies for cloudfoundry-incubator/kubo-deployment#252

@cf-gitbot cf-gitbot removed the delivered label Jan 10, 2018
@shinji62
Copy link
Contributor Author

@shinji62 shinji62 commented Jan 10, 2018

@cfdreddbot
Copy link

@cfdreddbot cfdreddbot commented Jan 10, 2018

Hey shinji62!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@akshaymankar akshaymankar reopened this Jan 10, 2018
@cf-gitbot
Copy link

@cf-gitbot cf-gitbot commented Jan 10, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/154206003

The labels on this github issue will be updated when the story is started.

Copy link
Contributor

@akshaymankar akshaymankar left a comment

LGTM

@cf-gitbot cf-gitbot added scheduled and removed unscheduled labels Jan 10, 2018
@akshaymankar akshaymankar merged commit 9c287b1 into cloudfoundry-incubator:master Jan 10, 2018
1 check passed
1 check passed
concourse-ci/status Concourse CI build success
Details
@cf-gitbot cf-gitbot removed the scheduled label Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.