Add to kubelet option to configure allow-privileged #153
Conversation
|
Hey shinji62! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/154049081 The labels on this github issue will be updated when the story is started. |
|
@glestaris @tvs thanks |
|
same here, is this covered by https://www.pivotaltracker.com/story/show/153848167? |
|
Well I think as good practices kube-apiserver and Kubelet should be able to be set to false and not only one of them as it is now.
… Le 4 janv. 2018 à 23:01, George Lestaris ***@***.***> a écrit :
same here, is this covered by https://www.pivotaltracker.com/story/show/153848167?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@shinji62 As the story mentioned by @glestaris is delivered and accepted, I guess this PR is not needed to be merged. Thanks anyways for your contribution :) I guess same applies for cloudfoundry-incubator/kubo-deployment#252 |
|
Please check with Georges. I know the story get accepted but as explained I think that bad pratice to not disable container privileged on kubelet too. Doesn t make sens as least for me.
Envoyé de mon iPhone
… Le 10 janv. 2018 à 18:41, Akshay Mankar ***@***.***> a écrit :
Closed #153.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Hey shinji62! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/154206003 The labels on this github issue will be updated when the story is started. |
|
LGTM |
akshaymankar
merged commit 9c287b1
into
cloudfoundry-incubator:master
Not sure is good to allow to true by default even if the apiserver is false.
This PR will put to false by default and add the options to setup to true.
I will send a PR to kubo-deployment too.