Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ca file required a file #156

Merged
merged 3 commits into from Jan 11, 2018

Conversation

Projects
None yet
4 participants
@shinji62
Copy link
Contributor

shinji62 commented Jan 9, 2018

For openstack ca-file should be a file not a string.

This PR introduce a new file called openstack-ca.crt.erb which will be filled with the ca-file parameters from the cloud-provider spec.

If nothing is given the file will be empty and not added to the cloud-provider config.

@cfdreddbot

This comment has been minimized.

Copy link

cfdreddbot commented Jan 9, 2018

Hey shinji62!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot

This comment has been minimized.

Copy link

cf-gitbot commented Jan 9, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/154166283

The labels on this github issue will be updated when the story is started.

@shinji62

This comment has been minimized.

Copy link
Contributor Author

shinji62 commented Jan 10, 2018

Adding proper unit testing

@BenChapman
Copy link
Contributor

BenChapman left a comment

Thank you for the pull request. Could you please add a templating test to make sure that the ca-file path gets set correctly when it's set in the manifest?

shinji62 added some commits Jan 9, 2018

@shinji62 shinji62 force-pushed the shinji62:fix/ca-file-openstack-cloud-provider branch from 5571de2 to c054e45 Jan 11, 2018

@shinji62

This comment has been minimized.

Copy link
Contributor Author

shinji62 commented Jan 11, 2018

@BenChapman I have added more test and rebase.
Should be ok.

@BenChapman BenChapman merged commit 56883a0 into cloudfoundry-incubator:master Jan 11, 2018

1 check passed

concourse-ci/status Concourse CI build success
Details

@cf-gitbot cf-gitbot added accepted and removed scheduled labels Jan 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.