Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adding removed flags #163

Merged

Conversation

@shinji62
Copy link
Contributor

@shinji62 shinji62 commented Jan 22, 2018

Since the logs level get lost during some commits.
This re-enable it.

@cfdreddbot
Copy link

@cfdreddbot cfdreddbot commented Jan 22, 2018

Hey shinji62!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

@cf-gitbot cf-gitbot commented Jan 22, 2018

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/154510082

The labels on this github issue will be updated when the story is started.

@shinji62 shinji62 force-pushed the shinji62:re_adding_missing_flag branch from 7f85edb to 3ff7bd9 Jan 22, 2018
@akshaymankar
Copy link
Contributor

@akshaymankar akshaymankar commented Jan 26, 2018

@shinji62 Good catch! Can you please add it to config.yml?

@akshaymankar akshaymankar self-assigned this Jan 26, 2018
@shinji62
Copy link
Contributor Author

@shinji62 shinji62 commented Jan 26, 2018

@shinji62
Copy link
Contributor Author

@shinji62 shinji62 commented Jan 29, 2018

This flag is a global flag which do not exist in the config.yaml file.

@shinji62 shinji62 force-pushed the shinji62:re_adding_missing_flag branch from 6b13435 to 9646104 Jan 29, 2018
Copy link
Member

@christianang christianang left a comment

LGTM

@christianang christianang merged commit 58d4d32 into cloudfoundry-incubator:master Jan 29, 2018
2 checks passed
2 checks passed
@cf-london
concourse-ci/status Concourse CI build success
Details
security/snyk - Gemfile.lock No dependency changes
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants